search

NIEHS / targets_PrestoGP

0 stars 0 forks source link

Covariate calculation codes #19

Closed sigmafelix closed 8 months ago

sigmafelix commented 8 months ago

I initially planned to make a pull request after I finish covariate calculation, but I think that the main branch needs to be up-to-date for the team's reference of reusable functions that are potentially related to NRTAPmodel and other projects.

I think the ddn git directory is in trouble, we could figure it out soon after settling the main branch.

kyle-messier commented 8 months ago

I initially planned to make a pull request after I finish covariate calculation, but I think that the main branch needs to be up-to-date for the team's reference of reusable functions that are potentially related to NRTAPmodel and other projects.

I think the ddn git directory is in trouble, we could figure it out soon after settling the main branch.

agreed - if we get the tests passing here and the main branch fine, then updating the "local" on the ddn project path should be doable

sigmafelix commented 8 months ago

I think both tests are supposed to be for a package development; do we want to reorganize the directories into a standard R package structure? If we do, we also need to consider the integration of the main development repository of PrestoGP. Maybe the pull will be possible after Sciome agrees to share the PrestoGP repository with us?

kyle-messier commented 8 months ago

@sigmafelix I just remembered we need to make folder changes (code -> R, etc.). Perhaps we should wait to see about integrating PrestoGP_Pesticides with PrestoGP (from the Sciome package build).

kyle-messier commented 8 months ago

@sigmafelix haha, agreed. I can bypass the tests and merge.

sigmafelix commented 8 months ago

@Spatiotemporal-Exposures-and-Toxicology Thank you. I will merge it into main and close this PR.