search

NIME-conference / nime-website

NIME Conference Website in Jekyll
5 stars 6 forks source link

Fixing searching bug on proceedings page #25

Closed dimitriaatos closed 4 years ago

dimitriaatos commented 4 years ago

Searching the proceedings page with Ctrl/Cmd+F (browser's Find feature) brings mostly results where nothing seems to be found (no highlighted text). search issue This makes the search-ability issues of NIME proceedings even worse than discussed in #4. The empty results appear because all abstracts and BibTex are included in the page's DOM even when they are not visible. The code responsible for this behaviour is the following: https://github.com/NIME-conference/nime-website/blob/a9f742607639767b556e770b4e9e170fb13f0cf0/assets/styles.scss#L55-L64 Making the max-height of abstracts and BibTex containers zero hides them but they are still searchable. Using display for hiding fixes the issue.

.collapse {
  display: none;
&.show {
    display: block;
  }
}
cpmpercussion commented 4 years ago

Good find! Not sure why I didn't do it that way in the first place, seems much more straightforward!