search

NIME-conference / nime-website

NIME Conference Website in Jekyll
5 stars 6 forks source link

Some of the Abstract and BibTex buttons in the proceedings page are not working #28

Closed dimitriaatos closed 3 years ago

dimitriaatos commented 3 years ago

Search for example for 10.5281/zenodo.1176342 in the proceedings page and try viewing the abstract or the BibTeX of the paper, nothing happens and the following error is printed to the console (chrome).

Uncaught DOMException: Failed to execute 'querySelectorAll' on 'Document': '.collapse.jtilbian:2017a-abstract' is not a valid selector.

It seems that the colon (:) in the class name causes the problem. If I'm not mistaken, the class names of each paper are generated from the citation key of the paper, that is found in the _bibliography/nime_papers.bib file. I found 23 citation keys that contain a colon, which means 23 broken Abstract and BibTex buttons in the proceedings page.

I guess it'll be safe to pass all citation keys through a function that removes the colon, before using them for class names.

alexarje commented 3 years ago

Thanks for finding this bug. What do you think, @cpmpercussion? The easiest may be to remove the colons from the citation keys. But a more robust solution is to change the code? Or we can do both...

cpmpercussion commented 3 years ago

Thanks for finding this! I've eliminated colons over in the bib repo and migrated them over here.