NJU-LHRS / LHRS-Bot

VGI-Enhanced multimodal large language model for remote sensing images.
Apache License 2.0
107 stars 9 forks source link

关于VG检测的问题 #27

Open zackhxn opened 2 months ago

zackhxn commented 2 months ago

作者您好,我在使用模型对RSVG数据集进行检测的时候,发现检测的可视化结果非常不好,例如: image image image 但是我使用main_vg.py同样复现出了71分的结果: [09/25 16:00:08 train]: Full config saved to /gpfsdata/home/zhangchenkai/LHRS-Bot/output_vg/config.json [09/25 16:00:08 train]: accelerator: gpu adjust_norm: false alignment_dim: 768 batch_size: 1 bf16: true bits: 16 config: null data_path: /gpfsdata/home/zhangchenkai/LHRS-Bot/rsvg/images data_target: /gpfsdata/home/zhangchenkai/LHRS-Bot/rsvg/RSVG_test.json double_quant: true dtype: float16 enable_amp: true entity: pumpkinn epochs: 2 eval: dataset: AID fp16: false generate: false gpus: 0 inf_sampler: false is_distribute: false local_rank: 0 lora: enable: false lora_alpha: 256 lora_bias: none lora_dropout: 0.05 lora_r: 128 lr: 0.0002 max_grad_norm: 0.3 model_path: /gpfsdata/home/zhangchenkai/LHRS-Bot/Stage3/FINAL.pt optimizer: adanp opts: null output: /gpfsdata/home/zhangchenkai/LHRS-Bot/output_vg project: MaskIndexNet prompt_template: llava_llama_2 quant_type: nf4 rank: 0 rgb_vision: arch: vit_large attn_pooler: num_attn_heads: 16 num_layers: 6 num_query: 144 input_patchnorm: false input_size:

[09/25 16:00:08 train]: Creating model /gpfsdata/home/zhangchenkai/miniconda3/envs/lhrs/lib/python3.10/site-packages/huggingface_hub/file_download.py:1132: FutureWarning: resume_download is deprecated and will be removed in version 1.0.0. Downloads always resume when possible. If you want to force a new download, use force_download=True. warnings.warn( Loading checkpoint shards: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:13<00:00, 6.95s/it] [09/25 16:00:42 train]: Data Length: 1227 [09/25 16:00:42 train]: Loading pretrained checkpoint from /gpfsdata/home/zhangchenkai/LHRS-Bot/Stage3/FINAL.pt [09/25 16:00:48 train]: Loading RGB encoder. [09/25 16:00:48 train]: After loading RGB encoder: Missing: []. Unexpected: [] [09/25 16:00:48 train]: Loadding LoRA parameters. Evaluating: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1.23k/1.23k [13:36<00:00, 1.50it/s] [09/25 16:14:37 train]: result file saved to /gpfsdata/home/zhangchenkai/LHRS-Bot/output_vg/eval_save_file.json [09/25 16:14:37 train]: Accuracy: 71.54088050314465 [09/25 16:14:37 train]: Fail Sample: 3 [09/25 16:14:37 train]: Accuracy With Fail Sample: 71.20500782472612 检查代码发现,在main_vg.py计算iou的函数中: def calculate_iou(box1, box2): x1, y1, x2, y2 = box1 x3, y3, x4, y4 = box2

intersection_x1 = max(x1, x3)
intersection_y1 = max(y1, y3)
intersection_x2 = min(x2, x4)
intersection_y2 = min(y2, y4)

intersection_area = max(0, intersection_x2 - intersection_x1 + 1) * max(
    0, intersection_y2 - intersection_y1 + 1
)

box1_area = (x2 - x1 + 1) * (y2 - y1 + 1)
box2_area = (x4 - x3 + 1) * (y4 - y3 + 1)

union_area = box1_area + box2_area - intersection_area

iou = intersection_area / union_area

return iou

您对intersection_area 、box1_area 、box2_area 都进行了+1处理,如果我没理解错的话,传入的参数box1, box2都已经是归一化的结果,进行+1会导致结果完全不正确(intersection_area 的值会算出来比较大,导致了iou也较大)。您在 https://github.com/NJU-LHRS/LHRS-Bot/issues/18 中提供的rsvg_eval_save_file.json 通过简单的手动查证就可以发现,前几个预测和真实的框完全没有重叠: image 如果按正确的方法计算iou,在RSVG上的结果只有1.88%

pUmpKin-Co commented 1 month ago

您好,

我们IoU代码参考自这里, 我看了一下,MiniGPT是计算基于Pixel Wise的Box计算IoU,我们归一化后+1会出现问题。 抱歉过程中没有很好的进行code review,我们将检查并及时修正。

感谢指出!

zytx121 commented 1 month ago

DIOR-RSVG的实验结果也存在相同的问题。MiniGPT-v2 甚至不用在遥感数据上微调就能达到80.65... 而在另一篇论文H2RSVLM中不用微调的模型得分大概在30-40这个水平,即使在训练集上微调了也不到50 image

怀疑另一篇论文 SkyEyeGPT 评测代码也有相同的 BUG, RSVG 和 DIOR-RSVG 的结果也有误。

image

我用 #18 中作者提供的RSVG和DIOR-RSVG预测结果,测出来的指标分别是0.31% 和 11.91%。我用作者提供的FINAL.pt 测出来的指标分别是1.72%和12.93%。下图展示了bug修复前后的分数差异:

image image

修复了一下现在的评测代码,把归一化之后的坐标转换回去:

import re
import json

def calculate_iou(box1, box2):
    """
    Calculate IoU between two horizontal bounding boxes (HBB).
    """

    # RSVG
    # box1 = [item * 1024 for item in box1]
    # box2 = [item * 1024 for item in box2]

    # DIOR-RSVG
    box1 = [item * 800 for item in box1]
    box2 = [item * 800 for item in box2]

    x1, y1, x2, y2 = box1
    x3, y3, x4, y4 = box2

    intersection_x1 = max(x1, x3)
    intersection_y1 = max(y1, y3)
    intersection_x2 = min(x2, x4)
    intersection_y2 = min(y2, y4)

    intersection_area = max(0, intersection_x2 - intersection_x1 + 1) * max(
        0, intersection_y2 - intersection_y1 + 1
    )

    box1_area = (x2 - x1 + 1) * (y2 - y1 + 1)
    box2_area = (x4 - x3 + 1) * (y4 - y3 + 1)

    union_area = box1_area + box2_area - intersection_area

    iou = intersection_area / union_area

    return iou

if __name__ == "__main__":
    answers_file = 'eval_save_file.json'
    pattern = r"\[([0-9., ]+)\]"
    with open(answers_file) as f:
        predictions = json.load(f)

    parse_result = []
    fail_instance = 0

    for item in predictions:
        pred_match = re.findall(pattern, item["pred"])
        if len(pred_match) == 0:
            fail_instance += 1

        try:
            pred_result = [list(map(float, match.split(","))) for match in pred_match]
        except:
            fail_instance += 1
            continue

        target_match = re.findall(pattern, item["target"])
        target_result = [list(map(float, match.split(","))) for match in target_match]

        new_pred_result = []
        new_target_result = []

        for pred, target in zip(pred_result, target_result):
            if len(pred) == 4:
                new_pred_result.append(pred)
                new_target_result.append(target)
            elif len(pred) > 4:
                while len(pred) != 4:
                    pred.pop()
                new_pred_result.append(pred)
                new_target_result.append(target)
            else:
                fail_instance += 1

        if len(new_pred_result) > 0:
            parse_result.append(
                dict(
                    filename=item["filename"],
                    pred=new_pred_result,
                    target=new_target_result,
                )
            )

    count = 0
    total = 0

    for item in parse_result:
        preds = item["pred"]
        targets = item["target"]

        for pred, target in zip(preds, targets):
            iou_score = calculate_iou(pred, target)
            if iou_score > 0.5:
                count += 1
            total += 1

    print(f"Accuracy: {count / total * 100:.2f}%")
    print(f"Fail Sample: {fail_instance}")
    print(f"Accuracy With Fail Sample: {count / (total + fail_instance) * 100:.2f}%")