search

NOAA-ORR-ERD / LibGOODS

Library for accessing data useful for the NOAA / GNOME model
https://libgoods.readthedocs.io/en/latest/
Other
1 stars 2 forks source link

End to end example #19

Closed yosoyjay closed 1 year ago

yosoyjay commented 2 years ago

Very basic end-to-end proof of concept example to build from.

kthyng commented 1 year ago

I think this PR doesn't work but #20 built from this and fixed things up.

ChrisBarker-NOAA commented 1 year ago

@kthyng: I'm not merging this, 'cause tests are failing. But I don't think the failures are due to these additions.

So please take a look and merge ASAP if possible.

kthyng commented 1 year ago

@ChrisBarker-NOAA No, this isn't valid anymore as other changes have happened in the meantime. I'll close this. For more info @lukecampbell can comment.

ChrisBarker-NOAA commented 1 year ago

This includes the new stuff that @lukecampbell pushed a couple days ago:

e2c2e92

So I think we want at least some of it :-)

kthyng commented 1 year ago

I think when you merged #20 it brought those updates into this PR.

ChrisBarker-NOAA commented 1 year ago

well, yes, which is why I want this PR merged :-)

Luke has posted it as a PR on this branch.

-CHB

kthyng commented 1 year ago

Ah, I finally understand! Thanks for spelling it out for me. I'm consulting with @lukecampbell.

kthyng commented 1 year ago

Ok, the working example is in #22 now and this branch is no longer needed. Everything needed for this work is in the other one, just to be clear.

ChrisBarker-NOAA commented 1 year ago

thanks!