NYCPlanning / db-data-library

📚 Data Library
https://nycplanning.github.io/db-data-library/library/index.html
MIT License
0 stars 1 forks source link

Default input missing on push triggering workflow #387

Closed fvankrieken closed 1 year ago

fvankrieken commented 1 year ago

And one other. See this failure

https://github.com/NYCPlanning/db-data-library/actions/runs/4734381721/jobs/8403220541

Workflows triggered by 'push' have no access to 'default' value for the workflow dispatch input, so need to specify another way

Fixed in below action, on push in this branch

https://github.com/NYCPlanning/db-data-library/actions/runs/4734427865

Verification that other option can be specified when using workflow dispatch (had swapped whether latest/staging was default here)

https://github.com/NYCPlanning/db-data-library/actions/runs/4734465371

fvankrieken commented 1 year ago

@damonmcc @mbh329 I'm totally purposefully leaning into small prs

fvankrieken commented 1 year ago

Verified that the way I've written it will grab given input if exists, or default to the second part of the or clause

mbh329 commented 1 year ago

yeah i like the small PR's, easier to digest. I very much understand the creation of a 'fix' branch name but I still think we should be more specific 😸

fvankrieken commented 1 year ago

yeah i like the small PR's, easier to digest. I very much understand the creation of a 'fix' branch name but I still think we should be more specific 😸

I meant it more as a joke since I keep leaving little errors that need little PRs to fix! Point taken re branch name