search

NYCPlanning / db-data-library

📚 Data Library
https://nycplanning.github.io/db-data-library/library/index.html
MIT License
0 stars 1 forks source link

Ar fac updates #410

Closed alexrichey closed 1 year ago

alexrichey commented 1 year ago

This is just a handful of various tweaks/notes made during the facdb data ingestion. (Note that one of the commits is just black'ing the ingestion.py file, so going commit-by-commit is a touch easier)

fvankrieken commented 1 year ago

Sorry if I'm missing the context elsewhere - why the change in process for nysed nonpublicenrollment?

alexrichey commented 1 year ago

Sorry if I'm missing the context elsewhere - why the change in process for nysed nonpublicenrollment?

@fvankrieken Context is here in the commit message body

fvankrieken commented 1 year ago

Sorry if I'm missing the context elsewhere - why the change in process for nysed nonpublicenrollment?

@fvankrieken Context is here in the commit message body

That's nysdec lands, I was asking about nysed nonpublicenrollment

alexrichey commented 1 year ago

That's nysdec lands, I was asking about nysed nonpublicenrollment

@fvankrieken My mistake! So this one does fail, I believe because the xlsx has two tabs. I should probably just specify the tab in the py script though. I'll give that a shot, and if it doesn't work then I'll add some context in the commit message.

alexrichey commented 1 year ago

@fvankrieken Specifying the sheetname works. Successful build here

Additionally, @fvankrieken / @damonmcc related PR here.