search

NYCPlanning / db-facilities

🏭 🏢 🏬 🏣 🏤 🏥 🏦 🏨 🏪 🏫 🏩
https://nycplanning.github.io/db-facilities
0 stars 0 forks source link

Change Program Name to original name in FacSubgrup lookup #571

Closed AmandaDoyle closed 2 years ago

AmandaDoyle commented 2 years ago

The Program Name is not changed when looking up the facsubgrp. By changing it the assignment of a facsubtype is failing.

SashaWeinstein commented 2 years ago

The fancy quote (’) was converted to a ? because of an encoding issue so it would be nice to keep it out if possible. Can the code be changed where facsubgrp is looked up to keep the regular quote?

AmandaDoyle commented 2 years ago

@SashaWeinstein The fancy quote is kept out in the final output, because the program name is passed through as the facility name. The program name is also used to assign the facility subgroup. When doing the lookup of the facility subgroup School''s Out New York City (SONYC) does not exist. School's Out New York City (SONYC)' is the value that exists in the data. I'm happy to talk this through if this is still unclear.

SashaWeinstein commented 2 years ago

Sorry I don't understand yet. I tried to look at the code by searching "facsubgrp" but couldn't find the code where program name is used to assign facility subgroup. I was thinking maybe we could change that code to carve out an exception for this category?

SashaWeinstein commented 2 years ago

Sorry that took me so long to see, it makes sense now. Got it in my head that the facsubgrp mapping happens farther downstream, didn't see that it was all within that one file.