search

NathanReb / ppx_yojson

OCaml PPX extension for JSON literals and patterns
BSD 2-Clause "Simplified" License
43 stars 5 forks source link

Issue #26: Remove useless metaquot #28

Closed ayc9 closed 2 years ago

ayc9 commented 2 years ago

Steps taken:

  1. Attempt at completing this issue on removing some unnecessary uses of metaquot
  2. Following metaquot readme to find list of antiquotation extensions. Only two cases found in ppx_yojson: %e and %p
  3. Searched for antiquotations of ast builders to find lines to simplify

For reviewer: Unsure if there are more uses of metaquot that should be removed. I tried to simplify lines like:

[%expr `String [%e Ast_builder.Default.estring ~loc s]]

But that creates type errors if String is removed. Do not know if there is a way to simplify and still includeString.

NathanReb commented 2 years ago

I need to fix the CI before merging though!

NathanReb commented 2 years ago

I fixed the CI bugs here: https://github.com/NathanReb/ppx_yojson/pull/29.

Can you rebase on top of main (sorry I also renamed the branch on the way) so we can get the CI to run and merge once it's green?

NathanReb commented 2 years ago

It seems something went wrong with the rebase so I cleaned it up myself but this is good to go now, thanks!