NativeScript / nativescript-plugin-seed

Get started building NativeScript plugins quickly.
Apache License 2.0
102 stars 54 forks source link

Remove --emulator flag scripts command #171

Closed mudlabs closed 5 years ago

mudlabs commented 5 years ago

Tell us about the issue

The script commands for Plugin Seed are implementing the --emulator flag. This makes the demo build and launch on the emulator when you execute npm run demo.<ios:android>, even if a device is connected. This can be removed because;

  1. If you have a device connected it's a good bet you want to run the demo on the device.
  2. If there's no device connected the demo will be deployed to an emulator by default.

Which platform(s) does your issue occur on?

Please, provide the following version numbers that your issue occurs with:

Please, tell us how to recreate the issue in as much detail as possible.

Follow the instruction for creating a plugin with nativescript-plugin-seed. When you execute, npm run demo.ios the demo will build and run on the emulator. Even if you have a device connected. (same is true for Android)