Navoei / CustomDiscs

A Paper plugin to add custom music discs using the Simple Voice Chat API.
MIT License
54 stars 13 forks source link

Silent playing (Pufferfish 1.20.1) #55

Open VladOliinyk opened 7 months ago

VladOliinyk commented 7 months ago

Hello there!

I am facing an issue that the music file is playing silently. So, /cd download ... and /cd create ... commands working fine, the Disc is created successfully, the item Lore is changed, and after putting the disc into Jukebox – the label appears – Now playing: <myfilename>, however: it is playing silently.

If putting the jukebox a short music file, like 3-4 sec long, the "notes" shows above the jukebox for a few seconds. If there is a 2m (~3mb mp3 file) song – the notes jumps quite long. So, based on that, making a conclusion that something is playing but.. not for me :)

Voicemod is working fine, we chat with other players quite well. Default music discs are playing fine. No console errors. The Music Discs player appears in the SimpleVoiceMod soundboard (so I can increase and decrease its volume as for a player).

So, idk what is the problem here. Tried both outdated SimpleVoice plugin versions (before v2.4.25), as well as exactly 2.4.25, as well as the latest one, 2.4.28.

Detailed server info:

Server has ViaVersion. Server is on Waterfall.

> version
[18:49:51 INFO]: Checking version, please wait...
[18:49:51 INFO]: This server is running Pufferfish version git-Pufferfish-8 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 2a6b66a on HEAD)
> pluginmanager info CustomDiscs
[18:47:31 INFO]: PM | Plugin Info:
[18:47:31 INFO]:  Name: CustomDiscs
[18:47:31 INFO]:  Description: A plugin which uses the Simple Voice Chat API to add custom music discs.
[18:47:31 INFO]:  Version: 2.5.1
[18:47:31 INFO]:  Author(s): Navoei
[18:47:31 INFO]:  The plugin is currently enabled
> pluginmanager info ProtocolLib
[18:50:32 INFO]: PM | Plugin Info:
[18:50:32 INFO]:  Name: ProtocolLib
[18:50:32 INFO]:  Description: Provides read/write access to the Minecraft protocol.
[18:50:32 INFO]:  Version: 5.1.0
[18:50:32 INFO]:  Author(s): dmulloy2, comphenix
[18:50:32 INFO]:  The plugin is currently enabled
> pluginmanager info voicechat
[18:50:43 INFO]: PM | Plugin Info:
[18:50:43 INFO]:  Name: voicechat
[18:50:43 INFO]:  Description: A working voice chat in Minecraft
[18:50:43 INFO]:  Version: 2.4.25
[18:50:43 INFO]:  Author(s): Max Henkel, Matthew Wells
[18:50:43 INFO]:  The plugin is currently enabled

btw, my client: Fabric 1.20.1

VladOliinyk commented 7 months ago

upd: VoiceChat config:

https://pastebin.com/vHwMRPLG

Navoei commented 7 months ago

Try changing the master volume in the custom disc config.yml.

VladOliinyk commented 7 months ago

Try changing the master volume in the custom disc config.yml.

Reloading the plugin goes wrong breaks the plugin I guess. An error occurred after using the disc on the jukebox (https://pastebin.com/dVH0ivrD) and no "Now playing" label above the jukebox.

After the server restart: no errors in the console, the label "Now playing" appears, but still "silent".

New config:

# [Music Disc Config]

# The distance from which music discs can be heard in blocks.
music-disc-distance: 16

# The master volume of music discs from 0-1. (You can set values like 0.5 for 50% volume).
music-disc-volume: 0.9

#The maximum download size in megabytes.
max-download-size: 50
VladOliinyk commented 7 months ago

just tested with music-disc-volume: 0.99 and also, have increased the boost value up to 300% and now I started hearing something, barely but I can hear the music from the audio file!

So.. my minecraft footsteps are like 500% louder than music from a disc, but it works!

So.. there are some troubles with volume.