search

NebulousLabs / skynet-js

A Javascript module made to simplify communication with Sia Skynet portals from the browser.
https://nebulouslabs.github.io/skynet-js/
MIT License
32 stars 12 forks source link

getSkylinkUrl with subdomain: true doesn't work from base32 skapps #303

Closed mrcnski closed 3 years ago

mrcnski commented 3 years ago

Example:

My skapp https://vg4hm678pvjltuh5nmmfimdi9jud7tggoda3eo4651uioqrii5oali0.siasky.net calls getSkylinkUrl("_AkeLeS84huwnOKEdP9o36dE1qJkmwHCVpzyFcMhv5d33A", { subdomain: true })

The result is https://vg4o10vtuj8j5np6rm4ujohmpaoksi9f9ei5ecnkguch74qgepbiobg.vg4hm678pvjltuh5nmmfimdi9jud7tggoda3eo4651uioqrii5oali0.siasky.net/.

The expected result is https://vg4o10vtuj8j5np6rm4ujohmpaoksi9f9ei5ecnkguch74qgepbiobg.siasky.net/.

This is probably impossible until https://github.com/NebulousLabs/skynet-webportal/issues/423 is implemented.

mrcnski commented 3 years ago

Closing in flavor of https://github.com/SkynetHQ/skynet-js/issues/4