NeoGraph-K / sd-webui-ddsd

ddetailer + sd-upscaler script
69 stars 15 forks source link

Enabled By Default? #4

Open xiaojiemeidu opened 1 year ago

xiaojiemeidu commented 1 year ago

20230421220917

And If I use imgimg-inpant to generate a picture, the generated picture preview is the original picture , Not the changed one. This function was correct prior to this update:<56099cf>.

NeoGraph-K commented 1 year ago

The symptom is an error caused by storing ui data used in previous versions in ui_config.json. It can be recovered by deleting the file or deleting the ddsd-related information inside the file. Also, i2i-related content is currently understood to be coming out with proper images. If you provide detailed errors and images, I'll try to figure it out more accurately.

xiaojiemeidu commented 1 year ago

The symptom is an error caused by storing ui data used in previous versions in ui_config.json. It can be recovered by deleting the file or deleting the ddsd-related information inside the file. Also, i2i-related content is currently understood to be coming out with proper images. If you provide detailed errors and images, I'll try to figure it out more accurately.

After deleting the ui-config.json file, restart the webui, and the "Enabled By Default" problem solved. When I use i2i-INPAINT the generated picture preview is this 20230422040016 Not the Mask_result 20230422040116 I think the Mask_result should be the correct preview

And the new version of the plugin will redraw the whole image, all areas out of the mask.(i2i-pnpaint)

NeoGraph-K commented 1 year ago

It is the correct way to display the final image from that I2I action. If the number of DINO Detect increases, the number of MaskResult also increases, because it is not known which image to display as a representative. In addition, when multiple images are created due to the increase in batch-count and batch-size, the number of masks is expected to increase very much, so only the final image is created. And inpainting of the non-mask area is the basic inpainting behavior of I2I. The extension is an action that additionally inpaints after the basic action. If you want to remove the basic inpainting, only DINO Detect can work if you inpaint with the denoise of the basic inpainting set to 0.

xiaojiemeidu commented 1 year ago

Maybe you should take a look at the problem I'm talking about. Now in img2img-inpaint, the generated image is the original image. Until the 56099cf update, img2img-inpaint will only change the image in the mask. (For example: Face) I think it's great. H44A6L2 Z1_ BI~WMO8SM92

NeoGraph-K commented 1 year ago

캡처

ah! Now I know the exact problem. If you check the image, disable I2I Mask Paint Mode exists, and the corresponding option works only with I2I. This option is a function that allows the masked mask to perform AND operation with the DINO Detect masking range during inpainting. When checked, it is configured to perform an and operation with the inner or outer range of the basic mask of inpainting, but the option was set in reverse. Thanks to this, by default, only the inside of the inpainting mask was configured to operate. I made a commit after the current fix.

xiaojiemeidu commented 1 year ago

캡처

ah! Now I know the exact problem. If you check the image, disable I2I Mask Paint Mode exists, and the corresponding option works only with I2I. This option is a function that allows the masked mask to perform AND operation with the DINO Detect masking range during inpainting. When checked, it is configured to perform an and operation with the inner or outer range of the basic mask of inpainting, but the option was set in reverse. Thanks to this, by default, only the inside of the inpainting mask was configured to operate. I made a commit after the current fix.

Check this 1 1 2 2 3 3 4 4

Please try it with this photo base

Another thing 5 like this 4

In i2i-inpanit 6 In this mode, I think Generate Working should not make any changes to the base image