NeogitOrg / neogit

An interactive and powerful Git interface for Neovim, inspired by Magit
MIT License
4.02k stars 236 forks source link

Use plenary.job for call_sync #1184

Closed eternity74 closed 7 months ago

eternity74 commented 8 months ago

This change helps to capture output of the command correctly. Current neogit.process implementation doesn't capture stdout correctly regarding empty lines and EOF.

This would help to remove the last empty line issue on #1108

CKolkey commented 8 months ago

seems reasonable, but I'll revisit the job handling when 0.10 drops and we get the vim.system api. I'd like to avoid wildly different implementations for sync and async calls, too

CKolkey commented 7 months ago

Going to shelve this as it's more likely we'll use vim.system instead