Closed saep closed 7 months ago
Cool - I'm a bit backlogged right now with stuff, but we'll get this merged in good time. Thanks for the PR
Alright. This is sweet. Nice work :)
Just a heads up, on the nightly branch I made these keys user configurable
When viewing the commit log, pressing
;
or,
can be used to open the commit view without focusing it. If you press;
again, it will scroll down the commit view. With,
you can scroll up. Because the commit view window isn't focused, you can quickly focus the next commit withj
or the previous withk
.This reduces the amount of key presses significantly when reviewing changes of multiple commits because you don't have to switch windows twice for every commit you want to look at.
Since
f
andt
are bound differently to normal vim usage,;
and,
are also basically free to use. On the US layout (and others), you only need the right hand to review the changes and can use the left hand to drink coffee or tee. ;-)These bindings implement the same functionality as
magit-diff-show-or-scroll-down
andmagit-diff-show-or-scroll-up
.This workflow is something that I've grown very accustomed to and one of the reasons I'm still using (Doom) Emacs at work. I also think, that it is useful for other people, so I've opened this PR. This is literally my whole magit-configuration: