fix: unlock gpg key on commit

NeogitOrg / neogit

An interactive and powerful Git interface for Neovim, inspired by Magit

MIT License

4.02k stars 236 forks source link

fix: unlock gpg key on commit #1196

Closed trevarj closed 7 months ago

trevarj commented 7 months ago

Make do_commit an interactive call in case there is a need to type in a gpg password before signing a commit.

Add an interactive flag to the opts for a wrapped command.

Fixes #1195

trevarj commented 7 months ago

@CKolkey hi, can you approve the CI workflow? thanks.

CKolkey commented 7 months ago

I'll have a chance to review this to see what kind of other things might be impacted soon. Really trying to make sure https://github.com/NeogitOrg/neogit/pull/978 is ready for when 0.10 drops.

trevarj commented 7 months ago

255 commits ahead of master.

Didn't even realize there is a nightly. Should I rebase onto that?

CKolkey commented 7 months ago

If you like, sure, but the surface area of your change is so small I don't think it would make a difference. Your call ;)

CKolkey commented 7 months ago

Seems to be fine - very nice fix! Thanks for digging into the issue.