NeogitOrg / neogit

An interactive and powerful Git interface for Neovim, inspired by Magit
MIT License
3.83k stars 228 forks source link

git-bisect support #1209

Closed famiu closed 5 months ago

famiu commented 5 months ago

Is your feature request related to a problem? Please describe. As far as I'm aware, Neogit has no support for git-bisect (or at least I could not find anything that mentions this in :help neogit or in the ? help popup). This is bothersome for me as git-bisect is a git feature I have to use fairly often, and having no way to do it inside Neogit is annoying. Furthermore, while I have not used Magit in a while, some searching leads me to believe that this is a feature in Magit: https://magit.vc/manual/magit/Bisecting.html.

Describe the solution you'd like Implement git-bisect in Neogit, similar to how Magit does it.

Describe alternatives you've considered Doing it in the command line, which is fine but it's a little annoying since Neogit already implements functionally everything else that I do in Git.

Additional context N/A.

CKolkey commented 5 months ago

Yeah, it's on my radar. I'll probably tackle this soon, no worries.

CKolkey commented 5 months ago

Alright, initial bisect support added on nightly branch! (requires neovim nightly).

B to bring up the popup :)

Some notes, since I haven't written docs:

Lemme know if you have any feedback on the UI/functionality.

famiu commented 5 months ago

@CKolkey Okay so, one thing I noticed is that it's not currently possible to open bisect from the ? help popup, maybe that's intentional? Also, when trying to do bisect with an arbitrary commit in the log, I keep getting this error: The good revision (78b04328da6a8587a2353e390cbebb4e0319d0a5) has to be an ancestor of the bad one (master)

I've checked this with multiple commits, all of which are ancestors of the bad commit, but it still doesn't work.

CKolkey commented 5 months ago

Ah, forgot to add it there. Good catch. I'll push some updates soon - I think I was checking the ancestry backwards 😅