search

NeogitOrg / neogit

An interactive and powerful Git interface for Neovim, inspired by Magit
MIT License
3.83k stars 228 forks source link

Rebase drop a commit #1213

Closed kjughx closed 5 months ago

kjughx commented 5 months ago

Based on this we can now also drop a commit.

I suggest to change the keybinding for dropping to "d" since it's unused in that view and feels more natural.

kjughx commented 5 months ago

I realize that I broke a lot of tests with the previous PR, I will try to fix them.

CKolkey commented 5 months ago

Thanks - but don't stress about it.. The test suite kinda sucks and is far flakier than I like. For example - the app can be working fine, and the tests are broken. To me that screams that it's testing either the wrong thing, or in the wrong way.

It's on my list of things to eventually rewrite it using either mini.test or https://github.com/lewis6991/nvim-test

Or possibly rspec (ruby) using RPC because it makes it way easier to handle concurrency/git repo state :D

CKolkey commented 5 months ago

Great stuff - Since we were in the neighborhood, I went ahead and implemented Autosquash, which was the last action to go! Thanks for helping with this :)