Invoking pull popup results in error

[skoch13]

Description

Being in a file I want to quickly pull changes from origin. Calling Neogit pull and then p results in error. In case that's vital for the repro: I use worktrees with bare repo. If I open Neogit tab and then call pull everything works as expected

Neovim version

NVIM v0.10.0-dev-2723+g981301d11 Build type: RelWithDebInfo LuaJIT 2.1.1710088188

Operating system and version

macOS 14.4.1

Steps to reproduce

1. edit a file
2. call Neogit pull
3. press p

Expected behavior

Neogit pulls changes from remote

Actual behavior

   Error  10:47:52 msg_show.lua_error E5108: Error executing lua ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...hare/nvim/lazy/neogit/lua/neogit/popups/pull/actions.lua:17: attempt to concatenate local 'branch' (a nil value)
stack traceback:
    [C]: in function 'error'
    ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: in function 'callback_or_next'
    ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:45: in function 'callback'
    ...are/nvim/lazy/plenary.nvim/lua/plenary/async/control.lua:101: in function 'returned_function'
    ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:31: in function 'callback_or_next'
    ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:45: in function 'step'
    ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:48: in function 'execute'
    ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:118: in function 'callback'
    ...cal/share/nvim/lazy/neogit/lua/neogit/lib/popup/init.lua:305: in function 'cb'
    .../.local/share/nvim/lazy/neogit/lua/neogit/lib/buffer.lua:597: in function <.../.local/share/nvim/lazy/neogit/lua/neogit/lib/buffer.lua:596>
    ...are/nvim/lazy/neogit/lua/neogit/lib/mappings_manager.lua:14: in function 'invoke'
    [string ":lua"]:1: in main chunk

Minimal config

-- NOTE: See the end of this file if you are reporting an issue, etc. Ignore all the "scary" functions up top, those are
-- used for setup and other operations.
local M = {}

local base_root_path = vim.fn.fnamemodify(debug.getinfo(1, "S").source:sub(2), ":p:h") .. "/.min"
function M.root(path)
  return base_root_path .. "/" .. (path or "")
end

function M.load_plugin(plugin_name, plugin_url)
  local package_root = M.root("plugins/")
  local install_destination = package_root .. plugin_name
  vim.opt.runtimepath:append(install_destination)

  if not vim.loop.fs_stat(package_root) then
    vim.fn.mkdir(package_root, "p")
  end

  if not vim.loop.fs_stat(install_destination) then
    print(string.format("> Downloading plugin '%s' to '%s'", plugin_name, install_destination))
    vim.fn.system({
      "git",
      "clone",
      "--depth=1",
      plugin_url,
      install_destination,
    })
    if vim.v.shell_error > 0 then
      error(string.format("> Failed to clone plugin: '%s' in '%s'!", plugin_name, install_destination),
        vim.log.levels.ERROR)
    end
  end
end

---@alias PluginName string The plugin name, will be used as part of the git clone destination
---@alias PluginUrl string The git url at which a plugin is located, can be a path. See https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols for details
---@alias MinPlugins table<PluginName, PluginUrl>

---Do the initial setup. Downloads plugins, ensures the minimal init does not pollute the filesystem by keeping
---everything self contained to the CWD of the minimal init file. Run prior to running tests, reproducing issues, etc.
---@param plugins? table<PluginName, PluginUrl>
function M.setup(plugins)
  vim.opt.packpath = {}                      -- Empty the package path so we use only the plugins specified
  vim.opt.runtimepath:append(M.root(".min")) -- Ensure the runtime detects the root min dir

  -- Install required plugins
  if plugins ~= nil then
    for plugin_name, plugin_url in pairs(plugins) do
      M.load_plugin(plugin_name, plugin_url)
    end
  end

  vim.env.XDG_CONFIG_HOME = M.root("xdg/config")
  vim.env.XDG_DATA_HOME = M.root("xdg/data")
  vim.env.XDG_STATE_HOME = M.root("xdg/state")
  vim.env.XDG_CACHE_HOME = M.root("xdg/cache")

  -- NOTE: Cleanup the xdg cache on exit so new runs of the minimal init doesn't share any previous state, e.g. shada
  vim.api.nvim_create_autocmd("VimLeave", {
    callback = function()
      vim.fn.system({
        "rm",
        "-r",
        "-f",
        M.root("xdg")
      })
    end
  })
end

-- NOTE: If you have additional plugins you need to install to reproduce your issue, include them in the plugins
-- table within the setup call below.
M.setup({
  plenary = "https://github.com/nvim-lua/plenary.nvim.git",
  telescope = "https://github.com/nvim-telescope/telescope.nvim",
  diffview = "https://github.com/sindrets/diffview.nvim",
  neogit = "https://github.com/NeogitOrg/neogit"
})
-- WARN: Do all plugin setup, test runs, reproductions, etc. AFTER calling setup with a list of plugins!
-- Basically, do all that stuff AFTER this line.
require("neogit").setup({}) -- For instance, setup Neogit

[CKolkey]

Oh, that makes sense. Repo state is coupled to the status buffer. Suppose if we let people skip that then it should be decoupled too. I'll try to push a fix tonight.

[CKolkey]

Alright, the fix for this will be in the next major release (when nvim 0.10 comes out). If you want to sooner, use the nightly branch :)

[skoch13]

I am already, thank you!