search

NeogitOrg / neogit

An interactive and powerful Git interface for Neovim, inspired by Magit
MIT License
3.83k stars 228 forks source link

rspec WIP #1226

Closed CKolkey closed 3 months ago

CKolkey commented 5 months ago

experimental RPC test suite

deril commented 5 months ago

It looks nice. But I am not sure that we need to bring another language to the codebase, which is needed to be supported.

CKolkey commented 5 months ago

@deril if this was in common lisp, you would have an entirely different attitude :P

star-szr commented 3 months ago

I ran out of steam contributing test coverage a while back because some things seemed to be untestable (sorry I would have to dig that out I don’t recall the exact issue), so I would be very interested if this makes things easier/smoother to test!

CKolkey commented 3 months ago

All good, man, I appreciate what you did regardless :)

Yeah, using ruby has a few advantages here:

And of course... i thought it would be interesting to use RPC to test neovim. Thats probably the only real reason hahaha.

I guess the downside is that people would have to write tests in ruby, but it's basically just me doing this anyways so... whatever. I like ruby 🤷‍♂️

Oh, and you can only really do E2E tests, but I think thats ok. I already unit test lua stuff when it's hard to get "correct", which wouldn't change.