Closed franklouwers closed 3 months ago
Cool, I'll have a look.
Ahhh, I'm dumb. I didn't escape the pattern matching - your -
is a valid lua pattern symbol and broke it. Easy fix - you should be set :)
Hi. I see you've closed this issue, but I don't see a commit / PR that mentions this. Is the fix in the Nightly? Or do I need to escape something in the config?
.... I was tired last night and forgot to push 😅 Sorry for the confusion, should be good now
Thanks @CKolkey I can confirm the url is detected now and my browser opens.
I still have another issue because of the way the gitlab urls are namespaced (git@host:group/subgroup/repo.git instead of the more traditional git@host:owner/repo.git), but I'll have some debugging time on my end ahead.
Here's where to start :) https://github.com/NeogitOrg/neogit/blob/nightly/lua/neogit/popups/branch/actions.lua#L266
Opened #1266 and #1267 to track and fix this
Description
I have a checked out git remote with a remote which is configured as:
The git remote is hosted on a self-hosted GitLab install at gitlab.x-plose.be.
I've added gitlab.x-plose.be as a git_service in my config with:
The
b o
command to open a pull request reports it can't find the correct service.Neovim version
NVIM v0.10.0-dev-2883+g2c5fd3f96-Homebrew Build type: Release LuaJIT 2.1.1710088188
Operating system and version
macOS 14.4.1
Steps to reproduce
git@gitlab.x-plose.be:k8s/customer/k8s.git
in a branchnvim -nu minimal.lua
:Neogit
b o
to open PR in a web browserExpected behavior
Web browser opens with the correct url.
Actual behavior
No webbrowser opens, neovim shows
Pull request URL template not found for this branch's upstream
Minimal config