Contributor tweaks - Githubissues

NeogitOrg / neogit

An interactive and powerful Git interface for Neovim, inspired by Magit

MIT License

4.08k stars 241 forks source link

Contributor tweaks #1352

Closed actionshrimp closed 5 months ago

actionshrimp commented 5 months ago

A couple of minor tweaks:

I couldn't get logger.fmt_debug to work - strangely it didn't error but it didn't seem to log anything either. I updated CONTRIBUTING.md to match how the rest of the code did it.
The tests were giving me an error as I'm on macos, but have GNU mktemp installed (there are at least 5 of us! 😆) - this detects GNU mktemp via --version rather than based on OS.

CKolkey commented 5 months ago

Yeah, no idea why fmt_* doesn't work.. Never dug too deeply into that. It's a vendored version of what plenary ships with, plus some minor tweaks. Not a huge deal to just pass a pre-formatted string in, so I haven't bothered.

Thanks for the other fixups :)