fix(help): correctly handle if `keymap` is `"<nop>"`

NeogitOrg / neogit

An interactive and powerful Git interface for Neovim, inspired by Magit

MIT License

3.62k stars 218 forks source link

fix(help): correctly handle if `keymap` is `"<nop>"` #1404

Closed mehalter closed 5 days ago

mehalter commented 5 days ago

Currently the help pop up is broken because keymaps can be equal to "<nop>". This correctly verifies that the keymap is a table before adding it so that it skips nops.

Even with a completely base, minimal installation, running ? doesn't work at all. This fixes that

mehalter commented 5 days ago

This issue looks to originate from: https://github.com/NeogitOrg/neogit/commit/43ac899fd0b8550241f189f63317bd20f97f3098

Miyelsh commented 5 days ago

Nice! I was chasing down this bug as well before seeing that you already made a fix.

Miyelsh commented 5 days ago

With your change, the help menu opens but some keybinds are not shown. With default neogit settings.

CKolkey commented 5 days ago

Thanks!