E-(x)hentai redesign - browse and latest no longer work.

[Solipso]

App version: 7.4.4-EH Issue/Request: E-hentai (and fjords) have undergone a redesign, maybe changing how their main page works. Now Tachiyomi can no longer see galleries on these pages, so "Browse" and "Latest" show "No results found".

[Solipso]

One new error caused by redesign - it seems like the app sees newly added galleries (by opening them as links on browser or batch adding), but is missing their thumbnails.

[Zero777X]

I am having issues as well with EHentai and EXHentai. "No results found" is my error text on the bottom of the screen. However, old titles are still viewable.

[hparadiz]

Bumping this as well. Whole app is basically broken.

[Cube-Chan]

Yup. Whole bunch of other sites also don't work anymore.

[LakotaGray]

You can still add new titles from the site in app by using the add batch galleries. You’ll just need to URL of the title, but it will then add properly and be able to be downloaded or viewed.

[smokeofc]

Syncing favorites seems to mostly remove all e-hentai titles from the library. Love this app and really hoping a fix is en route :)

[yalopov]

Bois we need to fix this ASAP.

Where can we start looking at?

[Solipso]

Well, considering that developer of this fork @NerdNumber9 was never online since august 2018 (at least to my knowledge), we can safely say that this project is dead.

That leaves us with few options:

1) We stay still and hope that @NerdNumber9 returns and fixes this (and all other) issues.

2) We go to @Inorichi and ask him to merge this fork or at least add local sources as extensions and to maintain e*hentai, tsumino, hentai cafe and hitomi with his team.

3) Someone else with knowledge of Kotlin and Java creates his own fork and begins to maintain this app.

[Scrxtchy]

Is anyone working on this already or should I take a look when I find the time?

[Solipso]

@Scrxtchy It would be the best if you took a look.

[Scrxtchy]

Better pop android studio back on this bitch then 😎

[ghost]

I created a temporary stopgap fix which re-enables searching and browsing of ehentai and the fjords. Favorites are broken though, I recommend disabling favorites syncing. I did this for myself / it's not very well tested, backup all your app data, etc etc:

Diff: https://github.com/ilwaz/TachiyomiEH/commit/0fac958e56bacba1c4b234f52474ed84a29d91f1 Release: https://github.com/ilwaz/TachiyomiEH/releases/tag/v7.4.5-EH

In terms of future steps, there have been some large changes to Tachiyomi recently, so getting us back to parity with source might be a bit of work. Unfortunately I won't be able to take that on for some time, so it might be best for someone else to attempt it.

[Scrxtchy]

I've pulled this commit into my own repo. I'm going to spend some time later to see how much we can do in terms of getting website scraping back up and running for the sites it does not work with. After that is gauged, if we can fix some with little effort, that could be done, but at some point the features from the main reader should be merged which may help with any further developments

[Scrxtchy]

Man can't even build this shit due to crashlystics lmao

[ghost]

@Scrxtchy, here's what I did: 1) Signup at fabric.io 2) Grab the api key from https://fabric.io/kits/android/crashlytics/install which they say to add to AndroidManifest.xml (but do not add it there). 3) Create app/fabric.properties with the contents apiKey={apk_key_value}

That fixed things for me.

Note: Crashlytics eventually moved to Firebase (which is owned and run by Google). Tachiyomi EH is on the old Crashlytics which needs a Fabric.io account. Tachiyomi itself has upgraded the the Firebase one though from what I can tell.

[Solipso]

Tried out @ilwaz's app. Both e*hentai online.

Remaining bugs from overhaul are favourites sync as mentioned earlier and few thumbnails not appearing normally in "Latest" and "Browse".

If you go to their info they show up normally though.

[RX14]

You can fix the crashlitics build error more easily by just commenting out apply plugin: 'io.fabric' in app/build.gradle

[RX14]

For reference, here's @NerdNumber9 on why tachiyomi-eh isn't a tachiyomi plugin: https://github.com/inorichi/tachiyomi-extensions/issues/94#issuecomment-325027557. This is at least useful as a guide on what needs to be ported to a plugin.

[Scrxtchy]

You can fix the crashlitics build error more easily by just commenting out apply plugin: 'io.fabric' in app/build.gradle

I did try this, but I think this caused some compiling errors in the kotlin files, issuing an API key fixed the error

[Scrxtchy]

I'm currently working on fixing the favourites parser that was marked as TODO by ilwaz https://github.com/Scrxtchy/TachiyomiEH/commit/0fac958e56bacba1c4b234f52474ed84a29d91f1#diff-38623e27ff84b67842f6dafccd22ab42R67

My build times are roughly 10-25 minutes

[kadaikhan]

Tried the @ilwaz 's app. It crashes when tapping the artist's name to start a search of that artist.

[Scrxtchy]

Thanks, also getting that on my end

[Solipso]

@kadaikhan Did you switch off hitomi source? It was causing crash since february.

Edit: No crash here. Hitomi disabled.

[kadaikhan]

@Solipso I didn't know about that. I did switch it off as you recommended and it seems that everything is ok for now, thank you. Would use more the @ilwaz 's app to see if I find another problem and post it here if I do. I just wish I knew how to program to help with this.

[Solipso]

@kadaikhan Sure! But before writing about it here, check local issues first. Some of them have solutions or bypasses.

[RX14]

I did try this, but I think this caused some compiling errors in the kotlin files, issuing an API key fixed the error

Try using the assembleFdroidDebug task after removing the fabric plugin. Builds much faster.

[Scrxtchy]

Is this the punishment I get for using gradle-aware make?

[Scrxtchy]

I've jumped through so many hoops for gradle today, spend seven hours fixing gradle and an hour programming. Classic

https://github.com/Scrxtchy/TachiyomiEH/commit/17ca4f185fe0b7f07a7f8d6de2cb4c0ba973d41d

Still working this out, Since I have no idea how exh used to handle styling of favourites, I've just attempted some things with it. (while writing this, I'm assuming this may be an image offset, did they use to use the diamonds?)

Now they're using border colours around the timestamp, so it's actually pretty hard. Like the simplest solution would be a regex, but they actually allow you to rename favourites

This unholy code better be worth it in the end, because getting this shit to a 0-10 scale is not going to be pretty

[Scrxtchy]

that wasn't too bad

Might need someone else to build this shit because I'd rather not make another deal with the devil and lose sleep over gradle fuckery https://github.com/Scrxtchy/TachiyomiEH/commit/7b781b8f9d8d29c8c0d1767218babf685b36f8ee

[joseph619]

@Scrxtchy Don't give up bro, we need your help :'(

[ghost]

I'll build it and publish it again, link incoming.

[joseph619]

@ilwaz Will Exhentai work as well?

[Scrxtchy]

Exh should be working fine. Favourites syncing is also fixed still having issues with some thumbnails, I know what's causing it to not work, but I don't know what's causing the data to break (DOM Parsing to find the image, but sometimes the image doesn't exist in the request)

[ghost]

Released with @Scrxtchy's recent fixes for favorites: https://github.com/ilwaz/TachiyomiEH/releases/tag/v7.4.6-EH

[joseph619]

Can't restore backup, stuck at 0%

Can't browse Ehentai, says 'Index: 1, Size: 1'

Exhentai appears to work however

[ghost]

Ah, I know the problem. Fix incoming

[Scrxtchy]

Incoming

[joseph619]

@ilwaz @Scrxtchy This fork has Nhentai working for Tachiyomi, check it out

https://github.com/az4521/Tachiyomi/blob/4838e86e8a0490f2b5956a0a94b8557fdcd8584c/app/src/main/java/eu/kanade/tachiyomi/source/online/all/NHentai.kt

[Scrxtchy]

Thumbnail Fix. broken thumbnails remain broken until a cache clear I suppose https://github.com/ilwaz/TachiyomiEH/pull/2

[Scrxtchy]

@joseph619 I'd rather probably just updating whatever we need to get tachiyomi-extensions properly working, as there is already team working on it https://github.com/inorichi/tachiyomi-extensions/tree/master/src/all/nhentai/src/eu/kanade/tachiyomi/extension/all/nhentai

This currently works in the regular tachiyomi versions, it just 404's for us

[joseph619]

@Scrxtchy: Are you going to remove Nhentai from this version, since there is already a working extension?

[Scrxtchy]

That's an option, I have already disabled hitomi.la due to it causing a critical crash, but I haven't done the same with nhentai as it wasn't much of an issue

[ghost]

Cut a new release with the thumbnail and ehentai browse fixes: https://github.com/ilwaz/TachiyomiEH/releases/tag/v7.4.7-EH

[joseph619]

I still see Hitomi under Settings

[Scrxtchy]

I still see Hitomi under Settings

Yes, but it is just removed from the source manager, so it cannot be used in galleries

https://github.com/Scrxtchy/TachiyomiEH/commit/dabf47b121c77a0769db6d7f4e6cde38db69df54

[joseph619]

@Scrxtchy Understood

Thumbnails in browse still don't load automatically, have to click on each title to load them

[Scrxtchy]

[Scrxtchy]

OH FOR FUCK SAKE I changed the wrong selector when dealing with @ilwaz's code review

https://github.com/ilwaz/TachiyomiEH/pull/2/files#diff-38623e27ff84b67842f6dafccd22ab42R78

it got past the both of us

[joseph619]

Edit: Nvm, backup seems to be working!

[kadaikhan]

@joseph619 if in your backup there is exhentai favs and you haven't log from the app in then it would not be able to load them.