Netflix / suro

Netflix's distributed Data Pipeline
Apache License 2.0
794 stars 170 forks source link

ElasticSearchSink sinkId should be different with the same cluster name #152

Closed metacret closed 9 years ago

metacret commented 9 years ago

Currently, the default sink id is "es_" + clusterName. If we have more than two ES sinks with the same cluster, its counter value will be duplicated displayed due to

String sinkId = counter.getConfig().getTags().getValue(SINK_ID);
                if (!Strings.isNullOrEmpty(sinkId) && sinkId.equals(getSinkId())) {
metacret commented 9 years ago

This was fixed on #172 because clientName will be unique in the instance.