Netflix / suro

Netflix's distributed Data Pipeline
Apache License 2.0
794 stars 170 forks source link

Configuration-based Module Load #191

Closed adamschmidt closed 9 years ago

adamschmidt commented 9 years ago

Added the ability to load modules from configuration (-x option on command line), removing the compile-time dependency. suro-server project can now specify modules as a runtime dependency.

cloudbees-pull-request-builder commented 9 years ago

NetflixOSS » suro » suro-pull-requests #5 ABORTED

adamschmidt commented 9 years ago

How come this aborted? I'm guessing that one of the test stages got stuck and exceeded the build timeout of 20 mins?

cloudbees-pull-request-builder commented 9 years ago

suro-pull-requests #171 FAILURE Looks like there's a problem with this pull request

metacret commented 9 years ago

I will take a look at the build. I need to fix flaky tests but it was low priority.

On Wednesday, February 11, 2015, CloudBees pull request builder plugin < notifications@github.com> wrote:

suro-pull-requests #171 https://netflixoss.ci.cloudbees.com/job/suro-pull-requests/171/ FAILURE Looks like there's a problem with this pull request

— Reply to this email directly or view it on GitHub https://github.com/Netflix/suro/pull/191#issuecomment-74003258.

cloudbees-pull-request-builder commented 9 years ago

suro-pull-requests #172 FAILURE Looks like there's a problem with this pull request

metacret commented 9 years ago

I found which test is stuck. I will fix and let you know, then you can merge the master and please update your PR.

adamschmidt commented 9 years ago

Hi Jae, this should be OK now?

metacret commented 9 years ago

Sure, I will merge today.

On Mon, Feb 16, 2015 at 3:17 PM, adamschmidt notifications@github.com wrote:

Hi Jae, this should be OK now?

— Reply to this email directly or view it on GitHub https://github.com/Netflix/suro/pull/191#issuecomment-74587869.