NetrunnerDB / netrunnerdb

A Deckbuilder for Android:Netrunner LCG
https://netrunnerdb.com
MIT License
144 stars 76 forks source link

System Core 2019 stays selected in collection #315

Open ghost opened 5 years ago

ghost commented 5 years ago

Every time I want to edit a new deck, System Core 2019 is checked again in collection, no matter if I previously unchecked it and saved the deck. Doesn’t matter if I log out and back in either.

For some reason, this is not a problem with older decks I’ve build, so must be a new bug.

plural commented 5 years ago

i tried to reproduce this and couldn't.

Does this happen as you go in and make new decks or does it happen for decks that you have recently saved and want to come back and edit?

Any further reproduction details you could provide would be awesome. I'll take another look later tonight as well.

ghost commented 5 years ago

Ah, I think I figured out the problem now. It only happens when creating new decks.

My group is playing with the Revised Core only right now (we'll expand!), so I only check Revised Core in 'Collection'. But all the ID's from Revised Core are used in System Core 2019 as well and are now tagged as belonging to that set. So when I want to create a Reina Roja deck, the system automatically checks the System Core 2019 in Collection.

I think there needs to be the same database distinction between Revised and System Core as between Revised and the old Core.

ghost commented 5 years ago

To reproduce, try this:

Make sure Collection only has Revised Core checked. Then create a new deck from scratch. Select any ID from Revised Core, pick Roja fx When the editor opens, the text under the ID will say "Cards up to System Core 2019", and when opening Collection again, System Core 2019 will be checked again.

Problem to be solved: The database treats the Revised Core IDs as belonging to System Core 2019 and thus automatically checks the System Core 2019 box in Collection. Every time I want to make a new deck I have to uncheck System Core in Collection and go to IDs and 'add' my ID (from 0 to 1 cards). Then the text changes to "Cards up to Revised Core". This is a pretty annoying thing to have to do every time.

mganjoo commented 5 years ago

I had this issue as well. In my case, I was trying to create a new deck (I only have the original Core Set, and am creating a deck for casual play). I selected Wünderkind from the Deckbuilder. I now see the text under the ID say "Cards up to System Core 2019", and "System Core 2019" is always checked automatically whenever I edit my deck.

However, even when I unselect System Core 2019 in Collection, go to the Build tab, and change my ID (as @simombo did above), I still see "Cards up to System Core 2019", and "System Core 2019" is still checked when I edit my deck again.

ghost commented 5 years ago

Did this get put on ICE?

If you don't play with Nisei cards yet, it is a lot of extra clicks you have to make to start building a deck.

I hope this gets fixed!

NoahTheDuke commented 5 years ago

What do you mean?

ghost commented 5 years ago

I mean: it hasn't been fixed.

NoahTheDuke commented 5 years ago

I'll close this issue when it's been fixed. Until then, consider it still happening.