search

NetrunnerDB / netrunnerdb

A Deckbuilder for Android:Netrunner LCG
https://netrunnerdb.com
MIT License
142 stars 76 forks source link

Feature Request: Suppress "Deck is a duplicate of X" on NISEI official account decklist postings. #508

Open BlueHairedHackerCatgirl opened 3 years ago

BlueHairedHackerCatgirl commented 3 years ago

To avoid confusion that a user is affiliated with nisei, the official listings of the Duel Decklists should not have the "Deck is a duplicate of [deck]" banner on them if possible. (see below image).

image

NoahTheDuke commented 3 years ago

This isn't currently possible. Is there any reason the official decks have been duplicated like this?

BlueHairedHackerCatgirl commented 3 years ago

Someone else posted them first?

plural commented 3 years ago

so i had to dig to see how this works. There is a parent decklist id field but that isn't why this is showing up. An md5sum of the cards in a deck is put into the signature field of decklist and that is checked to look for duplicates. I think that is silly. A manual test of setting the signature of the NISEI decklist to the md5sum of the decklist name fakes things out enough to suppress the dupe. The dupe functionality seems over-eager and silly though. There is a big difference between two people creating the same deck and copying a deck from another.

I can manually work around this for now, but we should think harder about how dupes/lineage is handled.

plural commented 3 years ago

"fixed" manually for now. Converting this to an enhancement to track dealing with it for the future.