NewAmazingPVP / ProxyPlayerNotify

A plugin to notify when a player joins or leaves the network or when they switch to another server
3 stars 0 forks source link

Add a new placeholder #4

Closed JuraRusan closed 4 days ago

JuraRusan commented 4 weeks ago

Please add a new placeholder in the form of %lp_suffix%.

Thank you!

NewAmazingPVP commented 4 weeks ago

Sure will look into this!

NewAmazingPVP commented 3 weeks ago

Hey there, @JuraRusan, could you try this build out and let me know if %lp_suffix works as intended? 

JuraRusan commented 3 weeks ago

Hi, unfortunately, I can only check on Monday.

NewAmazingPVP commented 3 weeks ago

Sure that's fine!

JuraRusan commented 3 weeks ago

Hey there @NewAmazingPVP. I can't download, it says: This content is no longer available.

NewAmazingPVP commented 3 weeks ago

Hey @JuraRusan, sorry the download links from the discord server expire after a while. Try this link

JuraRusan commented 2 weeks ago

I installed it, but something was wrong. Writes an error.

...
[12:28:11] [main/INFO]: Loaded plugin LuckPerms version 5.4.98 by Luck
[12:28:12] [main/INFO]:         __    
[12:28:12] [main/INFO]:   |    |__)   LuckPerms v5.4.98
[12:28:12] [main/INFO]:   |___ |      Running on BungeeCord - Waterfall
[12:28:12] [main/INFO]: 
[12:28:12] [main/INFO] [LuckPerms]: Loading configuration...
[12:28:12] [main/INFO] [LuckPerms]: Loading storage provider... [MYSQL]
[12:28:12] [main/INFO] [me.lucko.luckperms.lib.hikari.HikariDataSource]: luckperms-hikari - Starting...
[12:28:12] [main/INFO] [me.lucko.luckperms.lib.hikari.HikariDataSource]: luckperms-hikari - Start completed.
[12:28:12] [main/INFO] [LuckPerms]: Loading messaging service... [SQL]
[12:28:12] [main/INFO] [LuckPerms]: Loading internal permission managers...
[12:28:12] [main/INFO] [LuckPerms]: Performing initial data load...
[12:28:12] [main/INFO] [LuckPerms]: Successfully enabled. (took 743ms)
[12:28:12] [main/INFO]: Enabled plugin LuckPerms version 5.4.98 by Luck
...
[12:28:12] [main/INFO]: Loaded plugin ProxyPlayerNotify version 10.0 by NewAmazingPVP
...
[12:28:16] [main/INFO]: Enabled plugin ProxyPlayerNotify version 10.0 by NewAmazingPVP

Either I'm doing something wrong, or something isn't working right. ¯\_(ツ)_/¯

NewAmazingPVP commented 2 weeks ago

Weird @JuraRusan So the error is that it doesn't find a luckperms instance, aka the luckperms plugin. But clearly, luckperms is loaded before the plugin. Did you update the proxy version or luckperms version after the last time %lp_prefix% worked?

JuraRusan commented 2 weeks ago

I'm a little late with my answer.

Yes, I updated the proxy and plugin, but now there is no error, but the plugin displays placeholders, no final output

...
[15:31:55] [main/INFO]: Enabled Waterfall version git:Waterfall-Bootstrap:1.20-R0.3-SNAPSHOT:a65bb68:578
...
[15:31:55] [main/INFO]: Loaded plugin LuckPerms version 5.4.134 by Luck 
[15:31:56] [main/INFO]:         __    
[15:31:56] [main/INFO]:   |    |__)   LuckPerms v5.4.134
[15:31:56] [main/INFO]:   |___ |      Running on BungeeCord - Waterfall
[15:31:56] [main/INFO]: 
[15:31:56] [main/INFO] [LuckPerms]: Loading configuration...
[15:31:57] [main/INFO] [LuckPerms]: Loading storage provider... [MYSQL]
[15:31:57] [main/INFO] [me.lucko.luckperms.lib.hikari.HikariDataSource]: luckperms-hikari - Starting...
[15:31:57] [main/INFO] [me.lucko.luckperms.lib.hikari.HikariDataSource]: luckperms-hikari - Start completed.
[15:31:57] [main/INFO] [LuckPerms]: Loading messaging service... [SQL]
[15:31:57] [main/INFO] [LuckPerms]: Loading internal permission managers...
[15:31:57] [main/INFO] [LuckPerms]: Performing initial data load...
[15:31:57] [main/INFO] [LuckPerms]: Successfully enabled. (took 687ms)
[15:31:57] [main/INFO]: Enabled plugin LuckPerms version 5.4.134 by Luck
...
[15:31:56] [main/INFO]: Loaded plugin ProxyPlayerNotify version 10.0 by NewAmazingPVP
...
[15:32:00] [main/INFO]: Enabled plugin ProxyPlayerNotify version 10.0 by NewAmazingPVP
join_message: "&7[&a+&7] %lp_suffix%%lp_prefix%&#2bc9ff%player%"
switch_message: "&7[&b▶&7] %lp_suffix%%lp_prefix%&#2bc9ff%player% &7[%last_server%] → [%server%]"
leave_message: "&7[&c-&7] %lp_suffix%%lp_prefix%&#2bc9ff%player%"

There are no errors, I checked several times by rebooting the proxy, the plugin loads and works fine, messages are written as expected, logins/exits/change of server, but I see placeholders.

image

JuraRusan commented 2 weeks ago

config* https://paste.helpch.at/owiqobunic.yaml

NewAmazingPVP commented 1 week ago

Hey @JuraRusan Sorry for being so late, but try this build out.

NewAmazingPVP commented 1 week ago

image image Using your configs and latest luckperms and waterfall

NewAmazingPVP commented 4 days ago

Hey there, I have released the new version, and it should fix the issue. Please reopen this if it's still not working.

JuraRusan commented 1 day ago

@NewAmazingPVP Thank you very much, sorry, I didn't have a chance to check. If everything looks as good as the screenshot, then everything is great.

Thanks again!