search

No-57 / orange-frontstage-api

0 stars 2 forks source link

Correct the health API Endpoint #14

Closed shadow3x3x3 closed 11 months ago

shadow3x3x3 commented 1 year ago

The Health API Endpoint should be in /v1/health, not /api/v1/products/health.

Health APi is not belonged under products.

the base path /api/v1 should ref #15

shadow3x3x3 commented 11 months ago

It seems not correct in main branch. Please verify it again, thanks.

Report from @Vince-Ku.

https://github.com/No-57/orange-frontstage-api/blob/09df20426b389661eb1f5969107fa7eb5cb0142a/src/main/java/com/orange/main/products/controller/ProductsController.java#L58-L61

asdfg429 commented 11 months ago

@Vince-Ku Could you describe about the situation?

Vince-Ku commented 11 months ago

@asdfg429 ✅ https://{domainhost}/api/v1/health ❌ https://{domainhost}/api/v1/products/health

asdfg429 commented 11 months ago

Thanks. I'll check later.

shadow3x3x3 commented 11 months ago

This should be fine. Close.