search

Noam-Dori / ros-integrate

Extends IntelliJ-Based IDEs with ROS specific development tools
Apache License 2.0
22 stars 3 forks source link

CLion detection fixes #83

Closed maciejmatuszak closed 1 year ago

maciejmatuszak commented 1 year ago
Noam-Dori commented 1 year ago

I have no issue with this, just a few questions:

The code cleanup is also appreciated, of course

maciejmatuszak commented 1 year ago

CL-2022.1 fails to load with 

~/git/github/ros-integrate/src/main/java/ros/integrate/ui/PathListTable.java:5: error: cannot find symbol
import com.intellij.openapi.actionSystem.ActionUpdateThread;
                                        ^
  symbol:   class ActionUpdateThread
  location: package com.intellij.openapi.actionSystem

Versions CL-2022.2...CL-2023.1.1 can load the plugin with no problem Had to remove the changes in src/main/java/ros/integrate/settings/ROSSettingsPage.java as this would limit us to 2023 version onward.

Yeap, plexus is used for case change in just one place.