Noita-Together / noita-together

Play alone together
MIT License
44 stars 13 forks source link

Bank UI improvements (Unknown spells, All tab) #109

Closed tehkab closed 8 months ago

tehkab commented 8 months ago

Some improvements to the bank UI:

Proper handling of "unknown" spells and wands with them.

image image

Currently, spells that are in the bank but dont exist on the local client will 'crash' the bank UI and also cause lua error spam.

This is likely to be caused by either beta-branch spells on a non-beta client, or mod spells where the local player is missing the relevant mod.

Instead, we will render them with an obvious 'missing-texture' icon, and also add tooltip text to explain the issue. Also, the spell (or wand, if it is on a wand) will not be withdrawable from the bank - This doesn't actually seriously break Noita anyway, but it leaves the player with a useless dummy spell that doesn't actually do anything, so let's avoid that situation 😄

Fixing "all" tab

Went in and figured out what was breaking the 'all' tab when entering search text:

SkyeOfBreeze commented 8 months ago

fixes https://github.com/Noita-Together/noita-together/issues/107