Noita-Together / noita-together

Play alone together
MIT License
49 stars 15 forks source link

Refactor bank potions/bags, fix issues and do proper entity inheritance #88

Closed tehkab closed 1 year ago

tehkab commented 1 year ago

Potions and powder bags retrieved from the bank were implemented as copies of the original potion/powder_stash xml files with alterations. As a result, there were some changes that dont really make sense, as well as beta-branch changes not being applied.

Changed these to inherit from the proper vanilla definitions, overriding the LuaComponent responsible for filling them normally (so we can then fill them with proper banked materials). This also fixes some old changes that have odd effects on potions retrieved from the bank.

Potions retrieved from bank inherit from vanilla potion now:

Powder stashes don't have any obvious issues fixed by this, but changing them in the same way is consistent and should be more future-proof