Closed zuiderkwast closed 1 year ago
It seems that the 'startfrom' variable has lost its significance in the code. Should it be removed? Please confirm the code logic.
@zuiderkwast
LGTM! I'll guess it would be nice to add a test for XREAD as well?
I'll guess it would be nice to add a test for XREAD as well?
OK, done. Also changed the test for XREADGROUP so the group name and the consumer name are "streams", to make sure we don't mistake those for the STREAMS keyword (i.e. if we don't respect startfrom
we would get the wrong result).
The code for finding keys in XREAD and XREADGROUP commands was untested and incorrect. Here it is fixed and a test case is added.
Fixes #186