search

Nordix / hiredis-cluster

C client library for Valkey/Redis Cluster. This project is used and sponsored by Ericsson. It is a fork of the now unmaintained hiredis-vip.
BSD 3-Clause "New" or "Revised" License
86 stars 42 forks source link

Add Valkey support to the build and to the compatibility test in CI #210

Closed bjosv closed 4 months ago

bjosv commented 4 months ago

Adds the CMake option TEST_WITH_VALKEY_VERSION to enable make start to setup Valkey clusters instead of Redis. The default behavior, when the option is not set, is to run tests with Redis, but a given Valkey version takes precedence.

(Note: There is already an option to specify a Redis version TEST_WITH_REDIS_VERSION and Redis 6.2.1 is the default.)

Example usage:

mkdir build && cd build
cmake -DTEST_WITH_VALKEY_VERSION=7.2.5 ..

make start   # Start valkey clusters 
make test    # Tests run on valkey clusters
make stop    # Stop valkey clusters

Additionallty adds Valkey 7.2.5 to the compatibility test in CI.

zuiderkwast commented 4 months ago

Shall we leave this open until the next release candidate, or the actual release, is out?

bjosv commented 4 months ago

I guess you know best how far away an actual release is, and I've seen talks about possibly changing which patch-version to use. The only benefit to merge it before could be to get the script in place to tryout more, and locally run towards unstable now and then..

zuiderkwast commented 4 months ago

ok, do as you want.

the release is within a week.

bjosv commented 4 months ago

Updated to run on the first stable release of Valkey 7.2.5.