search

Novactive / NovaCollection

Collection implementation that wraps regular PHP arrays.
MIT License
9 stars 3 forks source link

[WIP] Unit testing for Collection and Factory #9

Closed nozavroni closed 7 years ago

nozavroni commented 7 years ago

I've started unit testing all the methods you've written so far. I did my best to not change anything (even if I felt it needed it) because this is supposed to be only unit tests and minor modifications to make failing tests pass.

Anyway, in the course of unit testing everything (so far), I'm noticing quite a few things I want to bring to your attention (@plopix), but not necessarily in order to change these things within this branch, just to start a conversation I guess. Anyway, I will try to finish unit testing by tomorrow night. Let me know if you need help with scrutinizer or anything. I'd like to have the test coverage reports so I can guage how much is left to test. Alright, talk soon! :)

nozavroni commented 7 years ago

@Plopix - BTW apparently my tests are failing on Travis. They're all passing on my machine. I'll get to the bottom of why that's happening and have it fixed ASAP.

Plopix commented 7 years ago

I have fixed the tests and the classes, it was failing for good reasons in Array/ForeachMethodCollection ;-)