Nukem9 / dlssg-to-fsr3

Adds AMD FSR 3 Frame Generation to games by replacing Nvidia DLSS-G Frame Generation (nvngx_dlssg).
GNU General Public License v3.0
3.85k stars 152 forks source link

Not working with Jack Sparrow Hogwarts Legacy #130

Open kecimydo opened 6 months ago

kecimydo commented 6 months ago

so apparently the mod doesn't work with Jhony depp version of the game. (LukeFZ works tho)

Capture d'écran 2023-12-19 225002 Capture d'écran 2023-12-19 225013 Capture d'écran 2023-12-19 225026 Capture d'écran 2023-12-19 225136

no RTSS or fps overlay was activated. also, i tried the normal version and DLSSTweaks version both aren't working if anyone here made it work in jack sparrow version let me know!

nanowell commented 6 months ago

I think @Nukem9 will have to reverse engineer Jack Sparrow Hogwarts Legacy calls to figure out this. I guess it's over.

Jackich2 commented 6 months ago

I have a steam license, it doesn't work

kecimydo commented 6 months ago

I have a steam license, it doesn't work

try this YT tutorial: https://youtu.be/q02WBUMZU2k?t=478

VladCorvi commented 6 months ago

the same. my build 1117238. A game cannot see .dll nothing helps. FG button is grey ofcs.

kecimydo commented 6 months ago

the same. my build 1117238. A game cannot see .dll nothing helps. FG button is grey ofcs.

LukeFZ mod works like a charm, sad it is paid for now

Jackich2 commented 6 months ago

I have a steam license, it doesn't work

try this YT tutorial: https://youtu.be/q02WBUMZU2k?t=478

I tried to do it like in the video and version 0.6 games work, i see FG in game.... But the game crashes If change dlss version file in game, game no see dlss xD

nefh commented 6 months ago

But the game crashes

@Jackich2 I've just played for 20 minutes HL, it worked flawless. Just place dlls here, with respect to steam library:

C:\Program Files (x86)\Steam\steamapps\common\Hogwarts Legacy\Phoenix\Binaries\Win64

I've used normal version, not DLSSTweak.

xSilock commented 6 months ago

the same. my build 1117238. A game cannot see .dll nothing helps. FG button is grey ofcs.

LukeFZ mod works like a charm, sad it is paid for now

In what is lukes version different? Why are u trying this one over his?

Dravic commented 6 months ago

the same. my build 1117238. A game cannot see .dll nothing helps. FG button is grey ofcs.

LukeFZ mod works like a charm, sad it is paid for now

In what is lukes version different? Why are u trying this one over his?

Trying to use DLSS3 Super Resolution (upscaling) with FSR3 Frame Generation is why.

Regular FSR3 implementations can't do that, they rely on FSR2 upscaling.

kecimydo commented 6 months ago

the same. my build 1117238. A game cannot see .dll nothing helps. FG button is grey ofcs.

LukeFZ mod works like a charm, sad it is paid for now

In what is lukes version different? Why are u trying this one over his?

LukeFZ uses FSR upscaling and is not stable a lot of ghosting and UI goes crazy, Nukem9 is stable.

Dravic commented 6 months ago

LukeFZ uses FSR upscaling and is not stable a lot of ghosting and UI goes crazy, Nukem9 is stable.

Too early to claim some vaguely superior stability when games keep crashing for people in various moments depending on the game and stuff like entire screen's edge ghosting (i.e. Cyberpunk 2077 when driving a vehicle, or turning camera sideways while on a broom in Hogwart's Legacy) are not yet resolved.

It's a great start though!

kecimydo commented 6 months ago

LukeFZ uses FSR upscaling and is not stable a lot of ghosting and UI goes crazy, Nukem9 is stable.

Too early to claim some vaguely superior stability when games keep crashing for people in various moments depending on the game and stuff like entire screen's edge ghosting (i.e. Cyberpunk 2077 when driving a vehicle, or turning camera sideways while on a broom in Hogwart's Legacy) are not yet resolved.

It's a great start though!

i use the mod on CP77 and i didn't find any disturbing artifacts or ghostings, LukeFZ is way worse you have to try it to understand.

Dravic commented 6 months ago

i use the mod on CP77 and i didn't find any disturbing artifacts or ghostings, LukeFZ is way worse you have to try it to understand.

Drive a car fast in a well-lit street (sunny weather during daylight), it's impossible to not see the entire screen ghosting at all times.

The video is stretched due to incorrect aspect ratio of the recording (sorry for that) but you can see the issue immediately here:

https://youtu.be/Z16_S5y8X80

use , and . buttons on your keyboard while watching YouTube vide to go frame by frame and you'll see this is 100% the Frame Generation as roughly every other frame won't have the ghosting layered on top of the frame.

Jackich2 commented 6 months ago
  1. Copy the 2 dll files Hogwarts Legacy\Engine\Plugins\Runtime\Nvidia\DLSS
  2. Copy the 2 dll files Hogwarts Legacy\Engine\Plugins\Runtime\Nvidia\Streamline\Binaries\ThirdParty\Win64
  3. Copy the 2 dll files Hogwarts Legacy\Phoenix\Binaries\Win64
  4. Clean AppData\Local\Hogwarts Legacy\Saved\Config
  5. DisableNvidiaSignatureChecks
  6. Do not include sharpness, reflex and vertical
kecimydo commented 6 months ago
  1. Copy the 2 dll files Hogwarts Legacy\Engine\Plugins\Runtime\Nvidia\DLSS
  2. Copy the 2 dll files Hogwarts Legacy\Engine\Plugins\Runtime\Nvidia\Streamline\Binaries\ThirdParty\Win64
  3. Copy the 2 dll files Hogwarts Legacy\Phoenix\Binaries\Win64
  4. Clean AppData\Local\Hogwarts Legacy\Saved\Config
  5. DisableNvidiaSignatureChecks
  6. Do not include sharpness, reflex and vertical

Not working too

Aidorin0 commented 6 months ago

Why people don't stay on topic? It seems It doesn't work in the Jack sparrow version, so the point is that someone with both versions test It. That's the only way to figure out if this is the real issue.

TruthAI commented 6 months ago

So you guys with the jack sparrow edition have to copy the files from "Hogwarts Legacy\Engine\Plugins\Runtime\Nvidia\DLSS\Binaries\ThirdParty\Win64" and "Hogwarts Legacy\Engine\Plugins\Runtime\Nvidia\Streamline\Binaries\ThirdParty\Win64" TO : "Hogwarts Legacy\Phoenix\Binaries\Win64" where the .exe is and of course then put the mod's files (should work with either the DLSSTweak edition with proper configuration or the normal one) and it will load and show the message (that the mod is loaded) just fine however my frame generation option ingame is still greyed out even with that, any one to test and see if it's a general issue or just me please?