search

Nukem9 / dlssg-to-fsr3

Adds AMD FSR 3 Frame Generation to games by replacing Nvidia DLSS-G Frame Generation (nvngx_dlssg).
GNU General Public License v3.0
3.84k stars 151 forks source link

HDR Support #14

Open Nukem9 opened 6 months ago

Nukem9 commented 6 months ago

HDR won't be supported any time soon. Don't use it.

Why? Because I don't own an HDR-capable monitor to test with.

edit: Testing is appreciated but ultimately I need a plethora of developer tools to debug games locally. Think Microsoft PIX, Nsight, Visual Studio, et cetera...

ForthtuN commented 6 months ago

If you change your mind and need some files or have some files up for testing im gladly doing it in case it could help to support HDR

Night1099 commented 6 months ago

If you change your mind and need some files or have some files up for testing im gladly doing it in case it could help to support HDR

Same for me

RaffCode-Personal commented 6 months ago

No HDR support makes this not interesting to me at all. I mean thanks for the work, but I wont give up one massive boost in image quality (on a good HDR screen) for something I would in the end use to enable other visual effects with less of an impact.

SomeMark commented 6 months ago

Hi! The mod works amazingly. I'm also willing to lend my help in testing the HDR version if you need it (my display is Samsung G7, not the best HDR but still better than SDR). My email: aganov.dm@gmail.com

oOldi commented 6 months ago

I want to help and participate in HDR testing My display is Alienware AW3423DWF

TimmyP777 commented 6 months ago

Id help. Puredark was able to hook HDR by using borderless for his DLSS mods, dont know if that applies here.

HDR is all you are missing. This is an incredible piece of software, and Ive been doing this a long time. You are gonna save people countless amounts of money, and stick it to these companies locking a generation of performance behind a single cheap feature.

devinbinnie commented 6 months ago

+1 on support for HDR, happy to lend a testing hand if need be. This mod is incredible, but yes my HDR monitor would like to be supported.

pho084 commented 6 months ago

if you open a virtual pot we will happily crowdfund you a HDR display @Nukem9 !

HDR support is necessary for this awesome piece of software

WEDGEinald commented 6 months ago

I made a account just to piggyback availability to test HDR support

Anyone who's played CP2077 with a good HDR monitor will know that once you play in HDR you don't go back

The game looks so flat by comparison

Hopefully you'll think of others feedback when deciding to add HDR support for either HDR-SRGB or HDR-PQ in-game

If this helps - without this mod I can select HDRSrgb and HDRPq as a in-game option (like normal) but with this mod installed I can only select the PQ version (it still crashes but maybe there's a clue there)

bennasar99 commented 6 months ago

Id you have an HDR phone or tablet you can also use https://github.com/itsmikethetech/Virtual-Display-Driver (virtual display with HDR support) with Moonlight. This way you can test HDR without an HDR monitor.

TimmyP777 commented 6 months ago

Bennasar that has zero to do with what is in here. Please remove your post.

niltecedu commented 6 months ago

Got a samsung s95b, willing to help out as well

bennasar99 commented 6 months ago

Bennasar that has zero to do with what is in here. Please remove your post.

Why? I tried something similar (with a Dummy Plug) and it allowed to play games with HDR on without an HDR monitor.

Care to explain?

TimmyP777 commented 6 months ago

In game HDR exists for a reason. Each game has its own HDR setup, sometimes dynamic, etc.

This was explicitly about in game HDR support in this FSR3FG\DLSS2 universal mod.

bennasar99 commented 6 months ago

In game HDR exists for a reason. Each game has its own HDR setup, sometimes dynamic, etc.

This was explicitly about in game HDR support in this FSR3FG\DLSS2 universal mod.

But the developer said he doesn"t have an HDR monitor to test and I'm suggesting a way to try HDR without an HDR monitor.

niltecedu commented 6 months ago

Tested NFS Unbound, HDR does indeed work.

ForthtuN commented 6 months ago

HDR also works in Microsoft flight simulator 2020

TheWoodsy commented 6 months ago

Win11, 3090, CP2077 HDR works with 0.50

moaazassali commented 6 months ago

HDR works with Alan Wake 2 as well with the 0.5 update

AlxNuga3v commented 6 months ago

Confirm that HDR works with 0.50 in AW2 and The Witcher 3 (Steam), no crashes have been detected. There's a little ghosting Win 11, RTX 3060

bennasar99 commented 6 months ago

HDR Works! CP2077 Win 11 RTX3070M

Thanks!

WEDGEinald commented 6 months ago

Came back to update as of mod version .50 HDR now works in CP 2077, at least for me! (HDR-PQ)

Win 11 I7 13700k 3080ti

ForthtuN commented 6 months ago

HDR won't be supported any time soon. Don't use it.

Why? Because I don't own an HDR-capable monitor to test with.

edit: Testing is appreciated but ultimately I need a plethora of developer tools to debug games locally. Think Microsoft PIX, Nsight, Visual Studio, et cetera...

Your latest version is confirmed, at least by me and many others now, to actually have working HDR support!

Thanks for this! Now i can enjoy it to my fullest

Nitro2137 commented 5 months ago

Does not work with HDR on in Cyberpunk, tested 0.5, 0.6, 0.7, 0.8, 0.81, dlsstweaks and non

You can turn it on, it loads, the framerate meter measures as if it is working (60% increase from non-fg), but the perceived smoothness remains as if it is off (halved/doubled frames effect). Back to dlss-fg - fully functional.

FSR3 doesn't have reflex mismatch issues (significantly lower gpu utilization), uses less vram than DLSS-FG and has a slightly better frame rate in general. But for Cyberpunk 2077 in my setup it only works in SDR as intended. I've tried all the fixes available here and there, including CFG exclusions, firewall exclusions, DDU, nvcp vsync/reflex tweaks, nvngx renaming, limiters, different game settings, so I can say with high confidence that it doesn't work in HDR. SDR experience is excellent though (with fsr3's own flaws, but that's another topic) - no problems there.

Weather-OS commented 5 months ago

R&C Rift Apart: HDR Doesn't seem to work on Windows no matter how hard I try. With my RTX 3060, The Mod only works when the game is running at 1080p and completely breaks at resolutions higher than 1080p. HDR Disables Frame interpolation and duplicates frames instead even at 1080p or 720p for that matter.

The only solution (for me at least) is to use Linux. I'm on a very experimental build of Proton and Wine. Not only is frame generation possible at 1440p, HDR Also works granted if you use gamescope.

Nitro2137 commented 5 months ago

I confirm that, despite being loaded, fsr frame generation does not work in HDR in Cyberpunk with the latest 0.9 patch.

jojodunet commented 5 months ago

I confirm that, despite being loaded, fsr frame generation does not work in HDR in Cyberpunk with the latest 0.9 patch.

Could you please share your .log file?

TimmyP777 commented 5 months ago

R&C Rift Apart: HDR Doesn't seem to work on Windows no matter how hard I try. With my RTX 3060, The Mod only works when the game is running at 1080p and completely breaks at resolutions higher than 1080p. HDR Disables Frame interpolation and duplicates frames instead even at 1080p or 720p for that matter.

In my case, HDR in RnC only works on very specific luminescence values in game. If you can enable it max the luminescence (1500), and slide down until you see it blink, then find the value it "blinked" on and HDR will magically be working. The first value mine worked at is 1311, I just checked this. 1312? Nope. Its a strange issue.

Nitro2137 commented 5 months ago

I confirm that, despite being loaded, fsr frame generation does not work in HDR in Cyberpunk with the latest 0.9 patch.

Could you please share your .log file?

dlsstweaks.log dlssg_to_fsr3.log

RikkTheGaijin commented 4 months ago

I can confirm that in CP2077 when HDR is ON, the FPS shows like the mod it's working, but just by moving the camera around it's clear that it's not. Please fix it! CP in HDR looks so much better...