Numelon-Softworks / ThreatenGL

Dear Minecraft, stop using outdated OpenGL versions... or else...
https://modrinth.com/mod/threatengl
Other
25 stars 0 forks source link

Neoforge 1.20.1 "not a valid mod file" #13

Open Snooziepup opened 4 months ago

Snooziepup commented 4 months ago

on trying to start the game with the mod Neoforge reports that it isn't a valid mod file :(

Richy-Z commented 4 months ago

Hello! I'm sorry to see that the mod is being frustrating on NeoForge 1.20.1. 😔

Would you mind clarifying what you mean by it saying it's "not a valid mod file"? E.g. does a window pop up saying that there's an error with the mod? Does Minecraft just quit unexpectedly? Do you see a long piece of text after Minecraft unexpectedly closed, a crash log?

Being as descriptive as possible will help me help you :)

Snooziepup commented 4 months ago

hi, an error screen pops up with the filename of the mod and the message, and a button to proceed to the menu screen but it halts the loading of the rest of the mods so theyre not actually loaded when on the menu

Richy-Z commented 4 months ago

Ohhh, I understand it now, the NeoForge mod warning screen.

Are you using the default Minecraft Launcher, MultiMC, Prism Launcher, the Modrinth App, the CurseForge app, etc? (Which launcher?)

Snooziepup commented 4 months ago

I'm using Prism Launcher.

ashley-graves commented 2 months ago

same issue here, was planning on adding this to my modpack

Richy-Z commented 2 months ago

Thanks for sharing! I thought this issue was resolved haha 😅 I'll look into it

ashley-graves commented 2 months ago

Thanks for sharing! I thought this issue was resolved haha 😅 I'll look into it

here's the error, might help ya out a bit

[05 Aug 2024 15:34:54.214] [main/ERROR] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Locator {mods folder locator at /home/ashley/.local/share/PrismLauncher/instances/posspack/.minecraft/mods} found an invalid mod file net.minecraftforge.fml.loading.moddiscovery.ModFileInfo@29c5ee1d
net.minecraftforge.fml.loading.moddiscovery.InvalidModFileException: Missing required field mandatory in dependency (threatengl-neoforge-1.3.2-beta.1.jar)
        at net.minecraftforge.fml.loading.moddiscovery.ModInfo$ModVersion.lambda$new$1(ModInfo.java:217) ~[loader-47.2.2.jar:47.2]
        at java.util.Optional.orElseThrow(Optional.java:403) ~[?:?]
        at net.minecraftforge.fml.loading.moddiscovery.ModInfo$ModVersion.<init>(ModInfo.java:217) ~[loader-47.2.2.jar:47.2]
        at net.minecraftforge.fml.loading.moddiscovery.ModInfo.lambda$new$8(ModInfo.java:100) ~[loader-47.2.2.jar:47.2]
Richy-Z commented 2 months ago

Thank you for sharing your error. A new version of ThreatenGL will be posted in a bit, I've found out that Forge has changed their mods.toml file structure.

Richy-Z commented 2 months ago

ThreatenGL 1.3.3 will be posted on Modrinth as soon as it finishes building 🤗 Thanks for reporting the issue!

Endri2015 commented 1 month ago

the warning is still coming in the latest version

FluffyWolfLord commented 1 month ago

yeah im getting the issue on latest version EDIT:should add more details yes im on prism and neo forge unsure why this happens but after clicking exit to menu is shows every single mod is disabled

Richy-Z commented 1 month ago

This is still on NeoForge 1.20.1 or 1.20.x?

Endri2015 commented 1 month ago

forge 1.20.1 not neoforge but it also does not work on neoforge

LuizLoyola commented 1 month ago

Error still exists:

LuizLoyola commented 1 month ago

Just realized I'm using the NeoForge version on Forge. This is the featured version for Forge on Modrinth. Using the correct version found on the versions page, it works.

image

Richy-Z commented 1 month ago

@LuizLoyola Modrinth automatically marked the NeoForge upload as Forge haha, sorry that's an error on my part as I didn't notice.

Richy-Z commented 1 month ago

The mislabelling on Modrinth has been corrected. However the mod still doesn't work on NeoForge either, right?

natpalmer-e4o4 commented 1 week ago

I can confirm that the issue still exists when using the NeoForge version of the mod on 1.20.1 through Prism Launcher

Oddly enough, using the Forge version allows everything to load correctly.