search

ODM2 / ODM2ControlledVocabularies

A Python/Django web application and REST API for managing the ODM2 Controlled Vocabularies, with SKOS and community moderation features.
http://vocabulary.odm2.org
BSD 3-Clause "New" or "Revised" License
4 stars 5 forks source link

Provenance field is getting cut off #25

Closed horsburgh closed 5 years ago

horsburgh commented 8 years ago

I just noticed that the URL in the "Provenance" field for some terms in the Relationship Type CV is getting cut off. For example:

http://vocabulary.odm2.org/relationshiptype/compiles/

This URL should be:

http://schema.datacite.org/meta/kernel-3/doc/DataCite-MetadataKernel_v3.1.pdf

I submitted a request to modify it, and the full URL is captured in the request, see:

http://vocabulary.odm2.org/requests/relationshiptype/fc9c98f7-f7f3-4fb1-913e-18b08f3a37be/

But when I look at the approved term after accepting the request, the field is still cut off.

Not sure if this is a front end issue, backend issue, or both?

denvaar commented 8 years ago

My first thought is that the field in the database is too short. I will have a look and fix it if that's the case.

denvaar commented 8 years ago

This was exactly the issue. I created an SQL script to change all of the provenance and provenanceUri rows from VARCHAR(100) to VARCHAR(300). That should hopefully be enough room.

I fixed this provenance term, but if it has been chopped off anywhere else, they will need to be edited.

denvaar commented 8 years ago

I will leave the closing of the issue to you, Jeff.

horsburgh commented 8 years ago

OK - I'm happy to fix the ones that are cut off. I'm assuming your script fixed all of the tables?

denvaar commented 8 years ago

Yes

denvaar commented 8 years ago

Both requests and normal tables for each cv.

aufdenkampe commented 5 years ago

Did this fix get pushed to production? I'm just trying to figure out what issues we should close.