OGKevin / ComBunqWebApp

A Bunq web interface made by bunqers
https://bunqweb.com
MIT License
26 stars 3 forks source link

An in-range update of semantic-ui is breaking the build 🚨 #137

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 2.2.12 of semantic-ui just got published.

Branch Build failing 🚨
Dependency semantic-ui
Current Version 2.2.11
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As semantic-ui is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/OGKevin/ComBunqWebApp/builds/261696435?utm_source=github_status&utm_medium=notification)

Release Notes Version 2.2.12 - Aug 07, 2017

Major Enhancements (1)

  • Dropdown - Dropdown can now have values specified in javascript when initializing.This should simplify cases where dropdown contents are contingent on other fields, for example listing sub categories. You can see some examples here and in the usage section of dropdown docs

Critical Bugs (3)

  • Dropdown - Fixed regression that caused sub menu dropdown inside ui menu to always appear on left edge of dropdown introduced 2.2.11 #5542
  • Popup - Fixed a regression with popup in 2.2.11 that caused popups to appear out of place in some cases due to incorrect calculation of offsetParent #5549 #5597 #5590
  • Build Tools - Fixes issue with deprecated uglify setting that could cause build tools to fail with the following error:
GulpUglifyError: unable to minify JavaScript
Caused by: DefaultsError: `preserveComments` is not a supported option

Enhancements (2)

  • Dropdown - Dropdown mutation observers now watch to see if the entire <select> DOM node is replaced with a different select, and not just if new <option> are added
  • Modal - Modal will now take into account absolutely positioned elements inside a modal when determining if scrolling is necessary. #5578 Thanks @lulalala

Bugs (4)

  • Dropdown - Fixed an issue where css rule for focused default text was not being applied for multiselects #5633
  • Dropdown - Calling dropdown methods on <select> will now work when using setting behavior to set settings after load #3744
  • Header - Fixes vertical alignment
  • Header/List - Fixes issue where icons appear slightly offset with text due to line-height offset fixes no longer being necessary in modern browsers.
  • Modal - Fixes issue where init order matters when multiple modals are shown at same time and allowMultiple: true is used #5559
Commits

The new version differs by 27 commits.

  • 577ae99 Rlsnotes 2.1.12
  • 415e9bc Rlsnotes
  • 7864436 Build 2.2.12
  • e198bdf Release notes
  • 4466494 Update rlsnotes
  • ef89b56 Merge pull request #5635 from Semantic-Org/revert-5543-next
  • 23f2a37 Revert "[Build Tools] Default theme folder can be configured"
  • 7450aa3 Fixes #5578, absolute positioned modal items are now taken into scroll calculation
  • 2849c90 #5559 rlsnotes
  • 4ccf825 Fix issue where multiple modal init order matters #5559
  • 44b8222 #5549 - Fix regression from offsetTarget change
  • 2abb6ed Merge pull request #5543 from LucasMoody/next
  • 48aaf9a #4872 #4850 Fixes issue with icon offset in header and list
  • 97750b7 Fixes issue with line height offset no longer being necessary #4780
  • a3b6fb6 Fixes issue with dropdown positioning being incorrect inside menus #5542

There are 27 commits in total.

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 2.2.11 your tests are passing again. Downgrade this dependency 📌.