search

OGKevin / ComBunqWebApp

A Bunq web interface made by bunqers
https://bunqweb.com
MIT License
26 stars 3 forks source link

Remove Payment ID and Account ID from transactions list #88

Closed basst85 closed 7 years ago

basst85 commented 7 years ago

I think this ID's have no added value? And they take unnecessary space :-)

OGKevin commented 7 years ago

Wel, when you want to export an payment, you will need the Payment ID. Then an API call will be made to get some payment info that is not shown in the table and creates the PDF. Also it would be useful if the user wants to view this payment in the bunq app. They could simply type in the payment ID and retrieve the payment. However this is not supported yet and I've contacted bunq to add support for this.

The account ID is there so the user know payments of which account he/she is viewing. I guess this could be removed from inside the table and shown above it with a little text saying: 'your viewing transactions from {account ID}.

But I think the payment ID should stay unless you have an compelling reason to remove it?

basst85 commented 7 years ago

You can add a button with the text "Export payment" or just "PDF" after each payment row.

And if there a multiple users than you can show a button "Show transactions" after each user. If there is only one user then you can always show them.

louis-lau commented 7 years ago

 I agree it clutters up the UI. For the actions a button with submenu for each row would be better. I'll see if I can whip up an example with the front-end redesign, it'll all take a bit though :P

OGKevin commented 7 years ago

@louis-lau Sounds good 👍. I wont be changing it then, you can change it in your redesign 😄.

louis-lau commented 7 years ago

Alright, I guess I'll just implement the front-end and you take it from there? 😁

OGKevin commented 7 years ago

@louis-lau yep