OGSR / OGSR-Engine

OGSR Project - Evolution of X-Ray Engine for S.T.A.L.K.E.R.: Shadow of Chernobyl
https://discord.gg/Q6QDxbNcfR
Other
473 stars 88 forks source link

Another animations issues #308

Closed romanpopulik closed 3 years ago

romanpopulik commented 3 years ago

I'm working now on AK74. Looks like anim_holster_g is not working, the game plays anim_holster_gl.

Also, anim_reload_partly_gl is not working, the game plays anim_reload_gl, but suprisingly proper sound is played (snd_reload_partly)

xrSimpodin commented 3 years ago

Also, anim_reload_partly_gl is not working, the game plays anim_reload_gl

Where did you find this animation name? Correct name: anim_reload_gl_partly.

Looks like anim_holster_g is not working, the game plays anim_holster_gl

Hmm, really. It looks like this is a bug. I can fix this.

romanpopulik commented 3 years ago

Where did you find this animation name? Correct name: anim_reload_gl_partly.

Ok, it works now.

xrSimpodin commented 3 years ago

Test this version please.

romanpopulik commented 3 years ago

Yes, it's fixed

romanpopulik commented 3 years ago

Another one: anim anim_shoot_g doesn't work

xrSimpodin commented 3 years ago

Must work:

void CWeaponMagazinedWGrenade::PlayAnimShoot()
{
    VERIFY(GetState()==eFire || GetState()==eFire2);
    if(this->m_bGrenadeMode)
    {
        //анимация стрельбы из подствольника
        m_pHUD->animPlay(random_anim(mhud_shots_g),TRUE,this, GetState());
    }
    else
    {
        if(IsGrenadeLauncherAttached())
            m_pHUD->animPlay(random_anim(mhud_shots_w_gl),TRUE,this, GetState());
        else
            inherited::PlayAnimShoot();
    }
}
romanpopulik commented 3 years ago

https://youtu.be/9GgCqU5xojw

Grenade is shooted, but animation is not played. anim_shoot_gl is played properly.

xrSimpodin commented 3 years ago

Apparently CWeaponMagazinedWGrenade::PlayAnimShoot() is not called at all when firing a grenade launcher.

romanpopulik commented 3 years ago

I tried vanilla files and engine. anim_shoot_g is not played too, but immediately after firing the grenade, the engine plays anim_reload_g

xrSimpodin commented 3 years ago

Fixed. Thanks for your report.