sahil-ondc commented 10 months ago

on_search_full_catalog_refresh

/message/catalog/bpp/providers/items/quantity/available/count must be equal to one of the allowed values (99,0)
invalid timestamp format in /message/catalog/bpp~1providers/locations/time

search_inc_refresh

/message/intent/payment/@ondc~1org~1buyer_app_finder_fee_amount must be string
Timestamp not in RFC 3339 (YYYY-MM-DDTHH:MN:SS.MSSZ) Format
context/city should be * while sending search_inc_catalog request

on_search_inc_refresh

bpp/fulfillments sent in payload shoulnd't be part of /on_search_inc_refresh api
bpp/descriptor sent in payload shoulnd't be part of /on_search_inc_refresh api
location should be sent only if there is any change in delta
Similar Item as in /on_search_full_catalog_refresh api call, item id - 4cbdd9c08c614d39884e40b1dd279341 a

@AnanthBo

sahil-ondc commented 10 months ago

Kindly submit Flow4 and Flow5 as well.

AnanthBo commented 10 months ago

We are currently using off network logistics and have added flow 4 & flow 5

sahil-ondc commented 10 months ago

on_search_full_catalog_refresh

placeholder values should not be provided for ex (categories)
message/catalog/bpp/providers items should have valid timestamp format RFC 3339 (YYYY-MM-DDTHH:MN:SS.MSSZ)

on_search_inc_catalog_refresh

keys with empty array should not be provided (fulfillments,locations,categories)
message_id should be unique in case of search_inc_mode is start

Note

Kindly provide on_search with variants as well

@AnanthBo

AnanthBo commented 9 months ago

@sahil-ondc , We dont support Variants as of now. so will upload the rest of the logs requested & share the PR

AnanthBo commented 9 months ago

@sahil-ondc Thank you for the comments. Please review at the earliest. Have fixed the requested comments of #172 in the #297 (which has New RSF commit & Retail + IGM fixes) https://github.com/ONDC-Official/v1.2.0-logs/pull/297

297 for RSF logs. - New +. Fixed push of #286 & #172 issue comments.

AnanthBo commented 9 months ago

@sahil-ondc Could you please review and give us a confirmation

AnanthBo commented 9 months ago

@bluecypher , could you please help us on this review.

sahil-ondc commented 9 months ago

Flow 1

on_search_full_catalog_refresh

/message/catalog/bpp/providers/locations/time/timestamp cannot be greater than context/timestamp
/message/catalog/bpp/providers/items/time/timestamp cannot be greater than context/timestamp
/message/catalog/bpp/providers/items/id cannot be same as /message/catalog/bpp/providers/items/parent_item_id

Other Flows

on_select

/message/order/quote/breakup/item/quantity/available/count should be in stringified integer format, it cannot be float or decimal

@AnanthBo

AnanthBo commented 9 months ago

@sahil-ondc , @bluecypher . The above is for retail logs. Can i assume the IGM logs are approved ? RSF logs are approved ? . How or when i will get the approved information ?

sahil-ondc commented 9 months ago

@AnanthBo This issue is regarding the Retail Seller Application logs only, please check RSF, IGM issue board as well.

AnanthBo commented 9 months ago

@sahil-ondc , Updated the Retail Logs for the above correction on On_select & On_search. Please let me know your comments at the earliest.

sahil-ondc commented 9 months ago

@AnanthBo Can you link the latest MR here in which you have fixed the issues ?

AnanthBo commented 9 months ago

@sahil-ondc PR #297 Brought in the retail fixes along with RSF.

sahil-ondc commented 9 months ago

Please check https://github.com/ONDC-Official/v1.2.0-logs/issues/172#issuecomment-1867614879 These issues are stil open

@AnanthBo

AnanthBo commented 9 months ago

@sahil-ondc , Below Pull has the Retail logs. requested for recent comments. Please review & let me know.

https://github.com/ONDC-Official/v1.2.0-logs/pull/370 Retail latest repush & IGM repush the latest test logs

CharanpreetChawla commented 9 months ago

Flow 1

/on_search

Categories not present even when parent_item_id is present in items

Flow 2

/on_select

slots and tracking are not available as per flow
message.fulfillments.type is not present. (Delivery/self-pickup)

/on_init

message.order.items[n].parent_item_id not present. (but present in on_search).

/on_confirm

message.order.items[n].parent_item_id not present. (but present in on_search).
message.order.fulfillments.tracking is "true". (but false in /on_select, /on_init)

AnanthBo commented 9 months ago

@CharanpreetChawla Can you please call 9845570864 or would like to discuss over a meet .

would like to understand two comments against on_select . Slots & tracking. We are using v1.2.0Ph1 and it is as per contract. would like to review once over call. Are you talking about the below 2 lines. as slot & tracking ? .
"@ondc/org/category": "Standard Delivery", "@ondc/org/TAT": "PT60M",

We do not provide food & beverages. so we do not provide tracking & immediate delivery. If TAT is a problem, will update. Please confirm this please.

would like to explain as you are looking at the old commit. ( as per request, parent_item_id has been removed in the recent On_search which has been submitted. Please check on_init & on_confirm against that parent_id ). Please confirm if this justification is enough? or should i provide flow 2 logs.

CharanpreetChawla commented 9 months ago

@AnanthBo,

Acknowledged, can proceed with the same ...
Please do resubmit the logs for the rest of flow with the related /search and /on_search as it was mentioned earlier comments about the problems in /on_select

AnanthBo commented 9 months ago

@CharanpreetChawla Submitted the logs with PR #403. https://github.com/ONDC-Official/v1.2.0-logs/pull/403

Please review and let us know your comments.

sahil-ondc commented 9 months ago

Flow 1

on_search_full_catalog_refresh

/context/bpp_uri should not end with '/'
/message/catalog/bpp/providers/id should not match message/catalog/bpp/providers/locations/id
/message/catalog/bpp/providers/items/tags cannot have values together 'veg', 'nonVeg', 'egg'
/message/catalog/bpp/providers/items/quantity/unitized/measure should be of the 'unit', 'dozen', 'kilogram', 'tonne', 'litre', 'millilitre'
@ondc/org/contact_details_consumer_care should be in the format 'name,email,contactno', invalid value provided 'Himachal Jams, marketing@costbo.com, '

Flow 2

on_select

City code mismatch in /search and /on_select

on_init

/message/order should not have property 'provider_location'
/message/order/quote/breakup/item/quantity/available/count should be in stringified integer format, it cannot be float or decimal
/message/order/quote/breakup/item should be as per the API contract

on_status

invalid timestamp provided in /message/order/fulfillments/end/time

@AnanthBo

AnanthBo commented 9 months ago

@sahil-ondc Addressed the comments above. Please review #437 https://github.com/ONDC-Official/v1.2.0-logs/pull/437

AnanthBo commented 9 months ago

@sahil-ondc , Can you please advise on the logs.

AnanthBo commented 9 months ago

@sahil-ondc would you be able to suggest comments - today please. So we can make progress over the weekend.

sahil-ondc commented 9 months ago

Flow 1

on_search_full_catalog_refresh

item_id: da1da524af79485eb95893cf5c98cc82 should have veg_nonveg one of the 'veg', 'non_veg', 'egg' in bpp/providers[0]
location in serviceability construct should be one of the location ids bpp/providers[0]/locations
location in serviceability construct should be one of the location ids bpp/providers[1]/locations

Flow 2

on_select

/message/order/quote/breakup/item/quantity available and maximum count logic should remain same as provided in on_search (99, 0)

on_confirm

provider.locations[0].id mismatches in /on_search and /on_confirm

on_status

/message/created_at should remain same as in /confirm call, when order was created
/message/billing/updated_at should remain same as in /init call

@AnanthBo

AnanthBo commented 9 months ago

Thank you Sahil. Will get back with fixes.

AnanthBo commented 9 months ago

@sahil-ondc PR#475 submitted. https://github.com/ONDC-Official/v1.2.0-logs/pull/475 Please review and approve.

AnanthBo commented 9 months ago

@sahil-ondc , could you please review and provide update.

sahil-ondc commented 9 months ago

Flow 1

search_full_catalog_refresh

/message/intent/fulfillment/end/location must have required property 'address'

on_search_full_catalog_refresh

context/timestamp of search call '2023-07-25T15:49:02.698Z', how on_search has been sent now with context/timestamp '2024-01-08T08:52:15.608Z'
category in serviceability construct should be one of the category ids bpp/providers[0]/items/category_id

Flow 2

on_init

billing issues
- Key 'phone' mismatch: 09845570864 !== 9845570864

@AnanthBo

AnanthBo commented 9 months ago

@sahil-ondc , Thanks for your comments. Have fixed them.
New PR#519 . could you please review.

AnanthBo commented 9 months ago

@sahil-ondc could you please provide an update today.

sahil-ondc commented 9 months ago

Flow 1

on_search

value should be "country" (code:"unit") for type 12 (PAN India) in /bpp/providers/tags
/message/catalog/bpp/providers/items/@ondc/org/time_to_ship should be in valid format 'ISO 8601'
how item 'Silk thread hook jhumka' be in category 'Beverages'

Flow 2

on_confirm

/message/order/fulfillment/start/time range cannot be same as /message/order/fulfillment/end/time

on_status

/message/order/fulfillment/start/time and /message/order/fulfillment/end/time should not change, should be same as provided in on_confirm

@AnanthBo

AnanthBo commented 8 months ago

@sahil-ondc This request. {{how item 'Silk thread hook jhumka' be in category 'Beverages'}}. >>. Please ignore, as this is a preprod test environment to test various categories we have assigned it.

Will submit rest of the fixes today

AnanthBo commented 8 months ago

@sahil-ondc , Retail logs have been submitted. https://github.com/ONDC-Official/v1.2.0-logs/pull/571 Please review and let us know.

AnanthBo commented 8 months ago

@sahil-ondc , could you please review & let us know

sahil-ondc commented 8 months ago

Flow 1

on_search

Beauty & Hygiene and Gourmet & World Foods are deprecated https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=0
/message/catalog/bpp/providers/items/tags[1]/list/code: veg on this value is yes when item is 'Meena Bead Rakhi'
The contact details for consumer care (@ondc/org/contact_details_consumer_care) should be in the format "name,email,contactno" in /bpp/providers[0]/items
/message/catalog/bpp/providers/items/time/timestamp is greater than context/timestamp

Flow 2

on_confirm

/message/order/fulfillment/start/time/range/start cannot be same as /message/order/fulfillment/end/time/range/end

@AnanthBo

AnanthBo commented 8 months ago

@sahil-ondc , PR#631 has been pushed for RET10. Please review & provide comments at the earliest pls.

sahil-ondc commented 8 months ago

Flow 1

on_search

/message/catalog/bpp/providers/location/address/street cannot be empty string ""
/context/city should be as per provided area_code in /message/catalog/bpp/providers/location/address
/message/catalog/bpp/providers/items/descriptor/code should be valid EAN number in case of code 1 as per API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.yr8id0fwawkv
/message/catalog/bpp/providers/items/@ondc/org/statutory_reqs_prepackaged_food should not have placeholder values

Flow 2

select

Buyer selects multiple items for checkout as per the sheet https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795

on_select

delivery line item must be present in quote/breakup (if location is serviceable)

on_status

un-solicited on_statuses must have different message_id

Flow 3

on_select (out-of-stock)

/error/message should be as per the API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.w0p6bcyawc9u

Flow 4

on_cancel

/message/order/tags should have 'quote_trail' as per the API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.yzl8pn3ixxec

@AnanthBo

AnanthBo commented 8 months ago

@sahil-ondc #683 has been submitted yesterday. Can you please review & approve.

AnanthBo commented 8 months ago

@sahil-ondc @bluecypher . PR #700 has been submitted with corrections suggested by Sandeep Shahi. Let us know your comments at the earliest.

AnanthBo commented 8 months ago

@sahil-ondc @bluecypher PR#712 has been submitted to remove the old retail logs.

AnanthBo commented 8 months ago

@sahil-ondc @bluecypher ,

PR #826 has been submitted with flow6 new requirement. (6c we have a exception from supriyo, as we are dealing with Grocery & not Fashion industry). This logs is for RET10.

sahil-ondc commented 7 months ago

Flow 1

on_search_full_catalog_refresh

/message/catalog/bpp/descriptor/tags/bpp_terms must have property np_type (ISN, MSN)
either one of '@ondc/org/statutory_reqs_packaged_commodities', '@ondc/org/statutory_reqs_prepackaged_food' should be provided in /message/catalog/bpp/providers/items (as per the sheet) https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=0
@ondc/org/contact_details_consumer_care contactno should consist of 10 or 11 digits without any spaces or special characters in /bpp/providers[0]/items
remove formatting from /message/catalog/bpp/descriptor/long_desc
bpp_terms should be provided in /message/catalog/bpp/descriptor/tags not in /message/catalog/bpp/providers/descriptor/tags
/message/catalog/bpp/providers/categories/id should be alphanumeric & up to 12 characters

Flow 3

on_select

/message/order/provider must have required property 'locations'

on_select (out-of-stock)

logs should be provided with items in stock until order-delivered as per the roll-out sheet https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795

Flow 4

on_cancel

/message/order/payment/uri should be same as provided in /confirm

Other Flows

on_select

/message/order/provider must have required property 'locations'

on_confirm

provider_tax_number (pan number of merchant) should be provided in /tags/bpp_terms

@AnanthBo

AnanthBo commented 7 months ago

PR#855 has been pushed. for review

sahil-ondc commented 7 months ago

Flow 1

on_search_full_catalog

item_id: f61e10aa600b412c9233caf0a8fae364 should have veg_nonveg one of the 'veg', 'non_veg' in bpp/providers[0]

Flow 2

on_status (accepted)

/message/order/fulfillment/state/descriptor should not be 'packed' in case of order/state 'Accepted' (check mapping) https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit

Flow 3

on_select (out-of-stock)

/message/orde/quote/breakup/@ondc/org/title_type 'discount' should only be provided in case of positive value

Flow 4

on_cancel

/message/order/fulfillments/tags/cancel_request should have 'precancel_state'

Flow 6

on_status (buyer-before-return)

Transaction log should contain the partial cancellation state

common

/message/orde/quote/breakup/@ondc/org/title_type 'discount' should only be provided in case of positive value

@AnanthBo

AnanthBo commented 7 months ago

@sahil-ondc

https://github.com/ONDC-Official/v1.2.0-logs/pull/929

We have submitted Retail. PR#929. - dated Feb24 - Full Set Flow1 - Flow6 - RET10. Please review & possibly provide a good news !!

sandeepshahi commented 7 months ago

/on_confirm

PCC is set as "value"; is this the value for merchant order no./pos no.
delivery TAT must be provided in /fulfillment/@ondc/org/TAT

/on_status

invoice should only be provided once the order is picked and thereafter
"Packed", "Out-for-delivery" states are missing

/on_cancel

contact/phone should be of 10/11 digits; check other APIs for similar issues ("on_cancel" and "on_update")
why are delivery/packing/misc fees being charged when order is cancelled at pending state
invalid code cancelled_by in /tags/cancel_request; should be "initiated_by" instead

/on_cancel (RTO)

RTO delivery charges in quote_trail should also be present as part of quote/breakup
invalid code cancelled_by in /tags/cancel_request; should be "initiated_by" instead
cancellation reason id mismtaches in fulfillments/tags/cancel_request and /cancellation ("015" vs "018")

/on_update (part cancel/liquidated)

quote_trail should be updated correctly; item and discount should be present as separate quote_trail line items

/update (FYI Refund)

update call with refund info is missing

@AnanthBo

AnanthBo commented 7 months ago

Sandeep, @bluecypher Submitted PR#992 RET10 full set for your review.

sandeepshahi commented 7 months ago

/on_status

order state must be "In-progress" when fulfillment state is "Packed"; check order and fulfillment state mapping here
invoice should be provided once the order is picked and thereafter; pls check for any similar system breaks
settlement_timestamp in /"@ondc/org/settlement_details" should only be provided when the amount is settled by the collector; won't be present here

/on_cancel (RTO)

updated_at timestamp for precancel_state (Out-for-delivery here) is not captued correctly; the timestamp provided is even before the order is picked

/on_status (RTO-Disposed)

order/updated_at timestamp should be updated correctly as per the change in order object

Ques: Are multiple fulfillment supported? If yes, how will multiple fulfillment ids be created?

@AnanthBo

BLR-0118 commented 7 months ago

Flow 1

/on_search (full):
- variant names should be more meaningful for the end buyer (as buyer apps will display this name);
- locations.address needs to be properly defined (locality can't be Bengaluru & entire address has been put into street);
- gps coords should be truncated to 6 decimals (which gives precision up to 100mm);
- considering that radial distance of earth is ~6000km, what does radius of 3000km here mean?
- many items seem to have the same EAN code 9146733310256: meaning?
- store timings per the new format is required;
/on_search (inc):
- pls share inc update for item going out-of-stock;

Flow 2

/on_select:
- what's the logic used to compute TAT of 5 days for delivery between 560053 (store loc) & 560103 (buyer loc)?
- quote is incorrect:
- item 7402* has price of 299 (as per catalog) but quote has MRP of 500;
- "discount" is for cart-level discounts, split across items & applied to selling price;
- same with item f61*;
/on_confirm:
- fulfillment TAT is 5 days but pickup slot is between 2nd & 4th Mar, while delivery slot is between 2nd & 7th Mar: how?
/on_status*:
- routing.type is reqd to allow buyer apps to differentiate between P2P & P2H2P;
- in /on_status_packed: fulfillment state "Packed" mapped to order state "Accepted" is incorrect;
- on_status for agent assigned is required;

Flow 6

/on_update (part cancel):
- quote_trail.type should match quote.breakup[].title_type;

BLR-0118 commented 7 months ago

@AnanthBo - pls resubmit flows 1, 2 & 6

ONDC-Official / v1.2.0-logs

Costbo (RET10/16) - compliance check #172

Note

297 for RSF logs. - New +. Fixed push of #286 & #172 issue comments.

Flow 1

Other Flows

Flow 1

Flow 2

Flow 1

Flow 2

Flow 1

on_search_full_catalog_refresh

Flow 2

on_select

on_confirm

on_status

Flow 1

search_full_catalog_refresh

on_search_full_catalog_refresh

Flow 2

on_init

Flow 1

on_search

Flow 2

on_confirm

on_status

Flow 1

on_search

Flow 2

on_confirm

Flow 1

on_search

Flow 2

select

on_select

on_status

Flow 3

on_select (out-of-stock)

Flow 4

on_cancel

Flow 1

on_search_full_catalog_refresh

Flow 3

on_select

on_select (out-of-stock)

Flow 4

on_cancel

Other Flows

on_select

on_confirm

Flow 1

on_search_full_catalog

Flow 2

on_status (accepted)

Flow 3

on_select (out-of-stock)

Flow 4

on_cancel

Flow 6

on_status (buyer-before-return)

common

Ques: Are multiple fulfillment supported? If yes, how will multiple fulfillment ids be created?

Flow 1

Flow 2

Flow 6