search

OWASP / Nest

Explore OWASP and be a part of it
https://nest.owasp.dev
MIT License
10 stars 11 forks source link

Implement Pagination for Contribute page #50 #60

Closed harsh3dev closed 2 weeks ago

harsh3dev commented 2 weeks ago

This Pull Request solves Issue #50

Made changes in 2 files:

backend/apps/owasp/api/search/issue.py --> added page parameter in get_issues() as well as: project_issues backend/apps/owasp/templates/search/issue.html --> Added Pagination UI and page change logic.

harsh3dev commented 2 weeks ago

@arkid15r I have run the necessary commands as told

harsh3dev commented 2 weeks ago

@arkid15r I went through your suggestions, firstly thanks for letting me know where I can improve Now I plan to do the following:

  1. Load the pagination component after the issues are loaded
  2. change the position of the buttons to center and page counter starts from 1 instead of 0
  3. Reset the page when user is searching
  4. Scroll to top after clicking Next/Previous
  5. The number of pages should be fetched from nbPages

I will consider all the changes and implement them for the new pagination component (React Based)

Also I think the backend for the pagination is sorted so I will push those changes with the new Component. Thanks

arkid15r commented 2 weeks ago

@arkid15r I went through your suggestions, firstly thanks for letting me know where I can improve Now I plan to do the following:

1. Load the pagination component after the issues are loaded

2. change the position of the buttons to center and page counter starts from 1 instead of 0

3. Reset the page when user is searching

4. Scroll to top after clicking Next/Previous

5. The number of pages should be fetched from `nbPages`

I will consider all the changes and implement them for the new pagination component (React Based)

Also I think the backend for the pagination is sorted so I will push those changes with the new Component. Thanks

Awesome! You summarized it right. It's a good idea to keep the code holistic and include the backend changes within your future PR.

Closing out this one and looking forward to reviewing more code from you soon. Thank you @harsh3dev!