search

ObjectVision / GeoDMS

Source code for the GeoDMS software
https://www.geodms.nl/
Other
7 stars 1 forks source link

connect_info_ne op v14 geeft {0,0} #687

Closed poorthuis-w closed 5 months ago

poorthuis-w commented 5 months ago

image

MaartenHilferink commented 5 months ago

Reproduced: Open d:\prj\pbl\vesta50\runs\s3f_d_lt30_70.dms; branch V_LD_v14; SourceDataProjDir=e:\SourceData\SD41_532

Ctrl-D op /TussenResultaten/R3_2030/GebiedsAllocatie/Lt30_70/impl/BronIterations/I0/ClusterSet/Connections

Geeft in debug-build met v14.14.1 een assertion failure op: image

image

MaartenHilferink commented 5 months ago

Bug was waarschijnlijk op 3 mei 2023 geïntroduceerd (versie 9.1.):

https://github.com/ObjectVision/GeoDMS/compare/v9.0.3...v9.1.0#diff-f4a409dbab65ef45ab39b234adba6ef275f08b2358fc41408f30b4d73991220f

image

MaartenHilferink commented 5 months ago

image

Ik zal vanmiddag een Prerelease van 14.14.1 maken met daar in deze fix.

MaartenHilferink commented 5 months ago

This issue is fixed in https://github.com/ObjectVision/GeoDMS/releases/tag/v14.14.1

Impact Assessment: The use of m_CutPoint in GeoDist.h and Connect.cpp indicate that this issue may have affected all results of connect and connect_info variants that should connect points to linestrings with only one point, which typically doesn't happen when connecting building point-locations to streets, but does happen when clustering point sources with connecting pipes.