OctarineSourcerer / cyberpunk2020

A FoundryVTT system for Cyberpunk 2020. It's playable now! There's a lot of hole, because there's a LOT of system to cover, but it should be mostly usable <3
23 stars 21 forks source link

Audit asyncs of rolls #108

Open OctarineSourcerer opened 2 years ago

OctarineSourcerer commented 2 years ago

Rolls are becoming async when evaluated. Where I can I've so far changed things to just explicitly await the result (there's no particular need to defer the rolls in this system right now). This all-awaited approach is pretty naive though, and may have rolls I've missed. It's worth looking at times [Roll].evaluate()is called and seeing whether rolls SHOULD actually be evaluated then, and whether they should be awaited.