search

OctarineSourcerer / cyberpunk2020

A FoundryVTT system for Cyberpunk 2020. It's playable now! There's a lot of hole, because there's a LOT of system to cover, but it should be mostly usable <3
24 stars 22 forks source link

Still issues with the skills #148

Open BrianC1970 opened 5 months ago

BrianC1970 commented 5 months ago

Hello again, first off thank you for the correction of the skills not having there assigned attributes. Now that I have updated to 0.3.11 it turns out that the edit button is not working and I can not edit the skills. I made a default custome skill for Expert and Languages, but now I can not edit them to say what they are. If I find any more issues I'll let you know.

BrianC Discord ID: brianc1970

OctarineSourcerer commented 4 months ago

Hi, thanks for reporting this! I've not gotten to test on Foundry v11 for a while, which is probably why I missed this. Slight typo meant that in Foundry v11 it was still trying to use Foundry v12 things. Let me know if this is fixed by 0.3.12.

BrianC1970 commented 4 months ago

Hello again, well I can edit now but when I do the drop down menu for stats shows me nothing but 'Object Object' Screenshot 2024-07-03 141938 I guess round 3 on a fix, lol.

BrianC Discord ID: brianc1970

mperfiljeva commented 3 months ago

Had the same issue with the skills yesterday. To add more details to the report: I've created a language skill for players, put them in their sheets, players edited it. Looks like this breaks skill editing across the world. From there any new or edited skills lose association with the stat, and the dropdown menu would only show "Object object" values. For example, here's a new skill created in the compendium: image

In addition, a skill like that cannot be rolled from the character sheet (clicking the button does nothing).

BrianC1970 commented 6 days ago

Any update on this, V12 version still not working right. Any update is greatly appreciated.

BrianC Discord ID: brianc1970

OctarineSourcerer commented 5 days ago

Apologies for the silence on this one! Life's been hella busy. I've just tried reproing on main - v0.3.12 of the package - but I can't seem to. I'd made the hotfix and then intended on releasing it Foundrywide if someone confirmed it worked on here.

I've just pushed a release on Foundry, so you shouldn't need to update via git. To be clear, this doesn't actually add code that wasn't here after July 2, but it does make that version available to those updating via Foundry. Does 0.3.12 work? As in, if you create a new skill, and follow the steps to reproduce this bug, does it still occur? image

If it does occur with new skills, this'll be interesting, and I'll probably need more info. If someone who can reproduce the problem could hit F12 for the dev console, and type in game.actors.getName("XXX").itemTypes.skill.find(skill => skill.name === 'YYY').system.stat where XXX is the name of an actor with the skill on, and YYY is the name of the skill, what does it show?

I suspect skills that have been "contaminated" by this might have to be reconstructed, but if I know what that "contamination" looks like, I may be able to do some kind of migration that fixes skills with the issue.

EDIT: I repro'd by going back to 0.3.10, though 0.3.11 might have it. Going back to 0.3.12 still showed the stat as being [object object] on the character sheet, but when editing it should now show the proper stats, and choosing one should fix it on the sheet too

BrianC1970 commented 1 day ago

Hello I just saw this and went to test it out and all is working. The character sheet now shows the proper stat for the skill and no issues in making a Skill and picking a stat. Thanks again for all you put into this project.

BrianC Discord ID: brianc1970