search

OctoMap / octomap_msgs

ROS package to provide messages and serializations / conversion for the OctoMap library
http://www.ros.org/wiki/octomap_msgs
32 stars 53 forks source link

Porting to ROS2 #11

Closed anasarrak closed 4 years ago

anasarrak commented 5 years ago

Can we create a ros2 branch to allocate these changes?

ahornung commented 5 years ago

I created a new ros2 branch, would you mind changing the PR to that one?

wxmerkt commented 5 years ago

@ahornung I just changed the target branch

@anasarrak Would it be possible to squash the changes down to a few meaningful ones - e.g., change-to-C++-14, change-to-amend-and-update-package-format, etc.?

Background: The changes to the msg and conversions-header files are good fixes and could also be added to the ROS1 version.

anasarrak commented 5 years ago

@wxmerkt I've made the requested changes, I don't know if it's what you are looking for, if you need any other change let me know.

anasarrak commented 5 years ago

@ahornung can we merge this?

wxmerkt commented 5 years ago

Can you please also cherry-pick and PR the conversions.h updates and message fixes to the ROS1 branch, then we can rebase the ros2 branch off that master - making the changes more minimal. Can you also please revert the change to README? Thank you :-)

anasarrak commented 5 years ago

@wxmerkt The only changes that can be applied on melodic, are the ones that are on the .msg and the changes on the headers from Octomap& msg to Octomap& octomap_msgs::msg, am I right?

wxmerkt commented 5 years ago

I thought so - but haven't tested.

wxmerkt commented 4 years ago

Superseded by #13