search

OctoMap / octomap_msgs

ROS package to provide messages and serializations / conversion for the OctoMap library
http://www.ros.org/wiki/octomap_msgs
32 stars 53 forks source link

Porting to ROS2 (New PR) #13

Closed RoboticsYY closed 4 years ago

RoboticsYY commented 4 years ago

Hi, since AcutronicRobotics cannot continue to support PR#11, this PR is a following effort along AcutronicRobotics' work to port this package to ROS2. Commit history of the original PR is reserved. Any new change requests can be addressed in this PR. PR#11 can be closed.

henningkayser commented 4 years ago

@ahornung @wxmerkt could you give this a review?

RoboticsYY commented 4 years ago

Could we also please backport the whitespace changes and the changes to the message files to minimise diversion of the two branches, and then also drop the unnecessary commits from history (README changes) before this is merged?

@wxmerkt The whitespace changes have been reverted. The current changes for the message files are necessary for a successful compilation.

@henningkayser I tried to squash the commits, but seems I cannot push to this branch.

henningkayser commented 4 years ago

@wxmerkt I cleaned up the commit history. @RoboticsYY thanks for preparing this!

wxmerkt commented 4 years ago

Thank you @henningkayser :-)